Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): publish weaver go modules #2415

Merged
merged 1 commit into from
May 9, 2023

Conversation

sandeepnRES
Copy link
Contributor

Chore:

  • chore(ci): publish weaver go modules
    This way of publishing all go modules in single commit will work as long as in the release commit, only version files are changed and script go-gen-checksum.sh in root directory is run, and no other changes are made between that commit and actual releasing (i.e. no other PR is merged affecting these go modules till release PR is merged).

Fixes:

  • fix(ci): update version only if tag has version

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES LGTM, thank you for working on this!

    fix(ci): update version only if tag has version

Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
@sandeepnRES sandeepnRES enabled auto-merge (rebase) May 9, 2023 05:50
@sandeepnRES sandeepnRES merged commit 008bd5b into hyperledger-cacti:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants