Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(weaver): prefix cacti to all weaver packages #2406

Merged
merged 1 commit into from
May 2, 2023

Conversation

sandeepnRES
Copy link
Contributor

@sandeepnRES sandeepnRES commented Apr 26, 2023

Set publish target to cacti

  • Update relay, drivers, iin-agent image registry to hyperledger/cacti
  • Update npm packages (protos-js and sdks) registry to cacti
  • Update maven packages registry to cacti
  • Rename sdks/besu/interoperation-node-sdk to sdks/besu/node
  • Rename modules with following convention <module-type>-<dlt-platform>:
    • For SDKs: sdk.corda, sdk-fabric, sdk-besu
    • For drivers: driver-corda, driver-fabric
    • For interoperation modules: imodule.corda
  • Change all packages version to v2.0.0-alpha-prerelease

@sandeepnRES
Copy link
Contributor Author

Large number of files are modified because of package name and registry changes to all weaver modules, which now targets to cacti. (Its mostly a find and replace)

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large number of files are modified because of package name and registry changes to all weaver modules, which now targets to cacti. (Its mostly a find and replace)

@sandeepnRES That's okay for cases when the only thing you do is these administrative changes (so I'm personally OK with this).
What I try to always avoid is having PRs that are doing some actual change in the logic/features AND mixing in huge diffs at the same time (because then if I go back later to look at that diff trying to figure out what was changed it is very hard because the large diff of the administrative changes are adding noise to the signal of the little diff changes of logic).
Just a long way of saying that I think that this LGTM. Thank you!

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepnRES sandeepnRES force-pushed the main branch 7 times, most recently from 06f4232 to a45152a Compare May 2, 2023 07:01
…rget to cacti

    - Update relay, drivers, iin-agent image registry to hyperledger/cacti
    - Update npm packages (protos-js and sdks) registry to cacti
    - Update maven packages registry to cacti
    - Rename sdks/besu/interoperation-node-sdk to sdks/besu/node
    - Rename modules with following convention `<module-type>-<dlt-platform>`:
        - For SDKs: `sdk.corda`, `sdk-fabric`, `sdk-besu`
        - For drivers: `driver-corda`, `driver-fabric`
        - For imodule: `imodule.corda`
    - Change all packages version to v2.0.0-alpha-prerelease

Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
@sandeepnRES sandeepnRES merged commit f37495c into hyperledger-cacti:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants