-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(weaver): prefix cacti to all weaver packages #2406
Conversation
Large number of files are modified because of package name and registry changes to all weaver modules, which now targets to cacti. (Its mostly a find and replace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large number of files are modified because of package name and registry changes to all weaver modules, which now targets to cacti. (Its mostly a find and replace)
@sandeepnRES That's okay for cases when the only thing you do is these administrative changes (so I'm personally OK with this).
What I try to always avoid is having PRs that are doing some actual change in the logic/features AND mixing in huge diffs at the same time (because then if I go back later to look at that diff trying to figure out what was changed it is very hard because the large diff of the administrative changes are adding noise to the signal of the little diff changes of logic).
Just a long way of saying that I think that this LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
weaver/core/drivers/corda-driver/docker-testnet-envs/.env.corda
Outdated
Show resolved
Hide resolved
06f4232
to
a45152a
Compare
weaver/core/drivers/fabric-driver/docker-testnet-envs/.env.n2.tls
Outdated
Show resolved
Hide resolved
weaver/core/drivers/fabric-driver/docker-testnet-envs/.env.n2.tls
Outdated
Show resolved
Hide resolved
…rget to cacti - Update relay, drivers, iin-agent image registry to hyperledger/cacti - Update npm packages (protos-js and sdks) registry to cacti - Update maven packages registry to cacti - Rename sdks/besu/interoperation-node-sdk to sdks/besu/node - Rename modules with following convention `<module-type>-<dlt-platform>`: - For SDKs: `sdk.corda`, `sdk-fabric`, `sdk-besu` - For drivers: `driver-corda`, `driver-fabric` - For imodule: `imodule.corda` - Change all packages version to v2.0.0-alpha-prerelease Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Set publish target to cacti
<module-type>-<dlt-platform>
:sdk.corda
,sdk-fabric
,sdk-besu
driver-corda
,driver-fabric
imodule.corda