fix(security): vulnerabilities found in cactus-whitepaper #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micoferdinand98
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
requested changes
Apr 12, 2023
There was a problem hiding this comment.
@micoferdinand98 LGTM but please make
- the commit subject unique
- copy that unique subject to match the issue name (rename the issue)
- also copy it to the PR title (e.g. keep it all consistent AND unique)
Suggestion to make it unique: include one or two of the most severe CVE IDs in the subject.
hi peter Good day I am done addressing the review points |
micoferdinand98
force-pushed
the
micoferdinand98/issue2038
branch
from
58fc593
to
1531584
Compare
sandeepnRES
approved these changes
Apr 21, 2023
petermetz
approved these changes
Jun 13, 2023
petermetz
force-pushed
the
micoferdinand98/issue2038
branch
from
1531584
to
7710c9d
Compare
Fixes hyperledger-cacti#2038 Signed-off-by: micoferdinand98 <ferdinand.m.b.mico@accenture.com>
petermetz
force-pushed
the
micoferdinand98/issue2038
branch
from
7710c9d
to
2e05280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(security): vulnerabilities found in cactus-whitepaper #2038