fix(relay): rust build fails after tokio bump from 0.2.25 to 1.18.5 #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryjones
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
@sandeepnRES sorry about closing your other PR, my mistake. |
|
@VRamakrishna @petermetz @takeutak you approved the previous version. I was doing a merge-deconfliction and messed up. |
|
Please don't merge this PR yet, there's another bug in relay introduced due to version upgrade, that I'm trying to fix and will add it in this PR itself. |
VRamakrishna
approved these changes
Mar 30, 2023
sandeepnRES
force-pushed
the
PR-2351
branch
3 times, most recently
from
5e696ad
to
f42ac31
Compare
Additionally:
- upgrade other dependencies for relay
- added tls based unit test in relay
- add retry logic in leveldb for open
- fix fabric testing workflows: go install bug
Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Signed-off-by: Ry Jones <ry@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2349
Replaces #2351 which I closed by accident