feat(fabric-socketio-connector): sending transactions signed on the client-side #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
@petermetz @jagpreetsinghsasan (cc: @izuru0) |
jagpreetsinghsasan
approved these changes
Jun 28, 2022
examples/cactus-example-discounted-asset-trade/transaction-fabric.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-fabric-socketio/src/main/typescript/connector/fabric-proto-serializers.ts
Show resolved
Hide resolved
|
This PR/issue depends on:
|
outSH
force-pushed
the
fabric_unsigned_proposal_pr
branch
from
afe7e1b
to
54d1f95
Compare
|
@petermetz Rebased and tested, ready for merge. |
outSH
requested review from
petermetz
and removed request for
sandeepnRES and
takeutak
…lient-side - Add functions to support entire process of sending transaction to the ledger without sharing any private key with the connector. - Add test cases to check the new functionalities. - Adjust asset-trade sample app to use new logic that doesn't send the private key to the connector. - Move fabric signing utils to a separate file. - Add fabric protobuf serializers and deserializers, so they can be send back and forth between connector and BLP without loosing type information. - Add an option to FabricTestLedgerV1 to allow attaching to already running ledger container. This can speed up test development/troubleshoot process. - Improve fabric-all-in-one ledger healthcheck, so that it waits for basic chaincode intialization. This is not strictly needed by current tests, but may be expected by future tests. - Refactor duplicated logic in fabric-connector. - Fix fabric-socketio module entry points (minor fix). Closes: 2070 Depends on: 2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
fabric_unsigned_proposal_pr
branch
from
54d1f95
to
9ec4008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any private key with the connector.
between connector and BLP without loosing type information.
This can speed up test development/troubleshoot process.
This is not strictly needed by current tests, but may be expected by future tests.
Closes: #2070
Depends on #2047
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
As always, please review only the last commit. Remaining ones are just dependencies, that will be squashed before an actual merge.