fix: custom-checks script from package.json does not work #1809 #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzell22
requested review from
jonathan-m-hamilton and
petermetz
as code owners
|
@petermetz based on your comment and suggestion (#1809 (comment)) , I have made a PR for package.json and yarn.lock changes and also tested it on my end. The changes gave a positive output.
|
petermetz
approved these changes
Apr 11, 2022
petermetz
requested review from
takeutak and
sfuji822
and removed request for
jonathan-m-hamilton
takeutak
approved these changes
Apr 11, 2022
…-cacti#1809 fixes: hyperledger-cacti#1809 Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
petermetz
force-pushed
the
fixcustomchecks1809
branch
from
47b64b4 to
ef543aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1809
Signed-off-by: ruzell22 ruzell.vince.aquino@accenture.com