Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade to Typescript v4.4 #1384

Conversation

Leeyoungone
Copy link
Contributor

Fixes #1129

Signed-off-by: Youngone Lee youngone.lee@accenture.com

@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 6 times, most recently from 26f15e1 to 9a8a643 Compare September 28, 2021 18:59
@codecov-commenter
Copy link

Codecov Report

Merging #1384 (039e484) into main (c2cee43) will decrease coverage by 0.00%.
The diff coverage is 1.60%.

❗ Current head 039e484 differs from pull request most recent head 9a8a643. Consider uploading reports for the commit 9a8a643 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   68.67%   68.67%   -0.01%     
==========================================
  Files         301      301              
  Lines       10878    10879       +1     
  Branches     1340     1340              
==========================================
  Hits         7471     7471              
- Misses       2709     2710       +1     
  Partials      698      698              
Impacted Files Coverage Δ
...src/main/typescript/default-consortium-provider.ts 96.15% <0.00%> (ø)
...erver/src/main/typescript/config/config-service.ts 74.15% <0.00%> (-0.85%) ⬇️
...ript/web-services/watch-healthcheck-v1-endpoint.ts 83.33% <0.00%> (ø)
...ctor-stub/web-services/deploy-contract-endpoint.ts 66.66% <0.00%> (ø)
...ctor-stub/web-services/run-transaction-endpoint.ts 84.84% <0.00%> (ø)
...r-stub/web-services/unprotected-action-endpoint.ts 85.29% <0.00%> (ø)
...kages/cactus-common/src/main/typescript/servers.ts 81.81% <0.00%> (ø)
...ript/web-services/register-web-service-endpoint.ts 93.33% <ø> (ø)
...cript/consortium/get-consortium-jws-endpoint-v1.ts 71.79% <0.00%> (ø)
.../typescript/consortium/get-node-jws-endpoint-v1.ts 76.31% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cee43...9a8a643. Read the comment docs.

@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 7 times, most recently from 377d833 to df884df Compare October 7, 2021 16:04
@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 6 times, most recently from 729d6b7 to d6fcc21 Compare October 13, 2021 17:35
@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 4 times, most recently from 356ef08 to 9be4e18 Compare November 1, 2021 15:46
@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 2 times, most recently from f674796 to cc1dbbf Compare November 17, 2021 06:13
awadhana and others added 4 commits December 29, 2021 14:40
Migrated test from Tap to Jest.

File Path:
packages/cactus-test-plugin-htlc-eth-besu/src
/test/typescript/integration/plugin-htlc-eth-besu
/initialize-endpoint.test.ts

This is a PARTIAL resolution to issue hyperledger-cacti#238

Signed-off-by: awadhana <awadhana0825@gmail.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Migrated test from Tap to Jest.

File Path:
packages/cactus-plugin-consortium-manual/src/test/
typescript/unit/consortium/get-node-jws-endpoint-v1.test.ts

This is a PARTIAL resolution to issue hyperledger-cacti#238

Signed-off-by: awadhana <awadhana0825@gmail.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@Leeyoungone Leeyoungone force-pushed the build-1129-upgrade-typescript branch 2 times, most recently from 2d91398 to 05b052e Compare December 30, 2021 21:38
Leeyoungone and others added 18 commits December 30, 2021 15:38
Fixes hyperledger-cacti#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Fixes hyperledger-cacti#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@Leeyoungone
Copy link
Contributor Author

@petermetz There are parts of this PR (newly merged Jest test files) that I have't been able to properly write try-catch for but I was wondering if I could open a separate for those migrated files. But for now, the checks are passing and the PR itself is already this big.

@petermetz
Copy link
Contributor

@Leeyoungone Sorry for the slow response, is this the same conversation we had the other day about splitting it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(deps): upgrade to Typescript v4.4
4 participants