build: migrate to Yarn v1 from npm v7 #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 73.19% 73.15% -0.05%
==========================================
Files 246 246
Lines 8619 8620 +1
Branches 996 996
==========================================
- Hits 6309 6306 -3
- Misses 1779 1783 +4
Partials 531 531
Continue to review full report at Codecov.
|
petermetz
added
dependencies
petermetz
force-pushed
the
deps-yarn-v1
branch
3 times, most recently
from
f1e9a39
to
3461a25
Compare
takeutak
approved these changes
Jul 19, 2021
petermetz
force-pushed
the
deps-yarn-v1
branch
2 times, most recently
from
12ba79c
to
dedb650
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
petermetz
force-pushed
the
deps-yarn-v1
branch
2 times, most recently
from
75e93d6
to
4776d81
Compare
Why? It was reported by other maintainers that yarn behaves much better in corporate proxy/firewalled environments. Future plans: Once Berry (Yarn v2) is stable, we should take a look at migrating onto that one. I did give it a try this time to see if their release candidate happened to be stable enough but it was not unfortunately (there were dependency resolution issues that lead the Yarn v2 not installing certain runtime dependencies at all so v1 it is for now) Also: 1. Made the CI not fail fast along the test matrix dimensions 2. Sequentialized the test:all script to always run one test at a time hoping to get some additional insight into the flaky tests this way. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Depends on #1111
Commit to review
Author: Peter Somogyvari peter.somogyvari@accenture.com
Author Date: Thu Jul 15 2021 22:10:04 GMT-0700 (Pacific Daylight Time)
Committer: Peter Somogyvari peter.somogyvari@accenture.com
Committer Date: Thu Jul 15 2021 22:12:29 GMT-0700 (Pacific Daylight Time)
build: migrate to Yarn v1 from npm v7
Why?
It was reported by other maintainers that yarn behaves much
better in corporate proxy/firewalled environments.
Future plans: Once Berry (Yarn v2) is stable, we should take
a look at migrating onto that one. I did give it a try this
time to see if their release candidate happened to be stable
enough but it was not unfortunately (there were dependency
resolution issues that lead the Yarn v2 not installing
certain runtime dependencies at all so v1 it is for now)
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com