Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(github): add knob/flag to manually override CI skip #2679

Open
petermetz opened this issue Sep 10, 2023 · 0 comments · May be fixed by #3574
Open

perf(github): add knob/flag to manually override CI skip #2679

petermetz opened this issue Sep 10, 2023 · 0 comments · May be fixed by #3574
Assignees
@zondervancalvez
Labels
backlog Tasks that are needed but we cannot prioritize them at present. Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Milestone
v2.1.0

Comments

@petermetz
Copy link
Contributor

petermetz commented Sep 10, 2023 •
edited
Loading

Description

As a maintainer I want to be able to make lots of small changes to scripts and so on so that the quality of the code is improving little bit little over time (or at least we keep it level, fighting code rot)

We have an initiative to dynamically analyze the diff so that test are only ran for packages that have code changes in them but this is hard to implement to cover edge cases like

  1. "Oh I just did a linter fix of typings (Typescript) and did not modify runtime code (JS)"
  2. I just added a newline to this bash script that the linter was telling me to fix
  3. I fixed an obvious bug in some build script that was failing it but I have a very high degree of confidence that this did not modify runtime behavior of production code.
  4. etc.

Acceptance Criteria

  1. Probably the best is to make it based on commit message body (the subject line is already crowded and we don't need need development specific noise in the release notes)
  2. Ideally this would be locked down to be used only by maintainers because otherwise malicious actors might try to sneak in malware by skipping security related CI checks that we have in place to prevent exactly that. I'm not sure how feasible this is but part of the issue scope here is to research the options to make that happen and write up a little report about each of those and which one could be the best and why.
@petermetz petermetz added good-first-issue Good for newcomers Developer_Experience Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-300-advanced Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium backlog Tasks that are needed but we cannot prioritize them at present. labels Sep 10, 2023
@petermetz petermetz added this to the v2.1.0 milestone Sep 10, 2023
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 7, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
680813d 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: Zondervan Calvez <zondervan.v.calvez@accenture.com>
@zondervancalvez zondervancalvez linked a pull request Oct 7, 2024 that will close this issue
Open
5 tasks
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 7, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
d050fb6 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: bado <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 8, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
faf119b 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: bado <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 9, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
edea1e5 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: bado <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 17, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
a547a30 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: bado <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 17, 2024
@zondervancalvez
perf(github): add knob/flag to manually override CI skip
487e517 
Primary Changes
----------------
1. Created a function to check if the commit message
contains 'cacti-skip-ci' to skip the CI check.
2. Check if the request is from the maintainer or not.
If he is a Maintainer, the CI-skip request will be
granted, else not.

Fixes hyperledger-cacti#2679

Signed-off-by: bado <zondervan.v.calvez@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zondervancalvez zondervancalvez

Labels
backlog Tasks that are needed but we cannot prioritize them at present. Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

perf(github): add knob/flag to manually override CI skip zondervancalvez/cactus
2 participants
@petermetz @zondervancalvez