Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector-iroha): sending transactions signed on the client-side #2077

Closed
outSH opened this issue Jun 15, 2022 · 0 comments · Fixed by #2078
Closed

feat(connector-iroha): sending transactions signed on the client-side #2077

outSH opened this issue Jun 15, 2022 · 0 comments · Fixed by #2078
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Jun 15, 2022

@outSH outSH added the enhancement New feature or request label Jun 15, 2022
@outSH outSH mentioned this issue Jun 15, 2022
Merged
outSH added a commit to outSH/cactus that referenced this issue Oct 4, 2022
@outSH
feat(connector-iroha2): sending transactions signed on the client-side
8b74234 
- Add new endpoint `generate-transaction`, to create unsigned transactions
  that can be signed on the client side.
- Add a function to iroha2-connector package to help signing iroha transactions
  on the client (BLP) side.
- Extend transact endpoint to accept signed transaction as an argument as well.
- Add new test suite to check features implemented in this PR (i.e. signing on the client side).

Relates to hyperledger-cacti#2077

Depends on hyperledger-cacti#2153

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Oct 4, 2022
Closed
izuru0 pushed a commit to outSH/cactus that referenced this issue Oct 12, 2022
@outSH @izuru0
feat(connector-iroha2): sending transactions signed on the client-side
ddb7d7b 
- Add new endpoint `generate-transaction`, to create unsigned transactions
  that can be signed on the client side.
- Add a function to iroha2-connector package to help signing iroha transactions
  on the client (BLP) side.
- Extend transact endpoint to accept signed transaction as an argument as well.
- Add new test suite to check features implemented in this PR (i.e. signing on the client side).

Relates to hyperledger-cacti#2077

Depends on hyperledger-cacti#2153

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Oct 14, 2022
@outSH
feat(connector-iroha2): wait for transaction commit
6cfda82 
- Add a new argument to transact endpoint to wait for transaction commit.
  When this flag is true, request will return with final transaction status (commit / reject).
- Add new transaction hash to all the responses from the transact endpoint.
- Alter tests to wait for status instead of waiting for X seconds to make them more reliable.
- Add new tests to check this PR features.

Relates to hyperledger-cacti#2077

Depends on hyperledger-cacti#2168

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(connector-iroha): sending transactions signed on the client-side outSH/cactus
1 participant
@outSH