Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cactus-api-client): common verifier-factory #1878

Closed
outSH opened this issue Feb 23, 2022 · 0 comments
Closed

feat(cactus-api-client): common verifier-factory #1878

outSH opened this issue Feb 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Feb 23, 2022

This is continuation of #1602

It turns out that we need a full VerifierFactory API that is compatible with both types of connectors/validators (both plain socketio and socketio/openapi), since it's already used by someone.

VerifierFactory will:

  • Read validator configuration (possibly from fs)
  • Create verifier only from validator id (defined in config). Optionally, there'll be argument for validator type for type safety.
  • Verifier will allow communicating with both validators in unified way.

We'd like this to be included in 1.0
@outSH outSH added the enhancement New feature or request label Feb 23, 2022
outSH added a commit to outSH/cactus that referenced this issue Feb 23, 2022
@outSH
feat(cactus-api-client): common verifier-factory
f94ea46 
Prototype for common verifier-factory like the one used in cmd-socketio
apps. More details in issue hyperledger-cacti#1878

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Feb 23, 2022
Merged
outSH added a commit to outSH/cactus that referenced this issue Feb 28, 2022
@outSH
feat(cactus-api-client): common verifier-factory
56a8f52 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Feb 28, 2022
@outSH
feat(cactus-api-client): common verifier-factory
875d82e 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Feb 28, 2022
@outSH
feat(cactus-api-client): common verifier-factory
8c450ac 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 1, 2022
@outSH
feat(cactus-api-client): common verifier-factory
4f2e0f3 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 2, 2022
@outSH
feat(cactus-api-client): common verifier-factory
2b57f69 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 2, 2022
@outSH
feat(cactus-api-client): common verifier-factory
534099f 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 3, 2022
@outSH
feat(cactus-api-client): common verifier-factory
af0b9de 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue Mar 8, 2022
@outSH @petermetz
feat(cactus-api-client): common verifier-factory
fff07d0 
Adjust SocketIOApiClient and common Verifier behavior to previous one in
cmd-socketio, fix related tests. Extract Verifier interfaces to common
location to ensure interface compatibility between old and new verifier
/ verifier factory (both should implement same interface). Create new
package cactus-verifier-client for common verifier related stuff, to
prevent circular dependencies. Add verifier-factory to create verifiers
by supplying it's ID only, based on initial configuration. Configuration
is set in ctor, but can be read from a file as in cmd-socketio
scenarious. VerifierFactory config should be compatible with existing
ledgerPluginInfo.

Closes: hyperledger-cacti#1878
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@outSH