Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ensure sorted package.json files #1341

Closed
petermetz opened this issue Sep 16, 2021 · 3 comments · Fixed by #1683
Closed

ci: ensure sorted package.json files #1341

petermetz opened this issue Sep 16, 2021 · 3 comments · Fixed by #1683
Assignees
@Leeyoungone
Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have

Comments

@petermetz
Copy link
Contributor

Description

Consistency of the package.json files could be improved via enforcing in the CI that package.json files are always sorted.

https://www.npmjs.com/package/sort-package-json

Acceptance Criteria

  1. Not just the root package.json but also all child package json files are checked for being sorted.
  2. CI fails if any of the package.json files are unsorted
  3. There is a convenience npm (yarn) script that performs the sorting at development time so that people don't ever have to do it manually (which is a chore)
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers Nice-to-Have Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-200-intermediate labels Sep 16, 2021
@Leeyoungone
Copy link
Contributor

May I also take this one?

@Leeyoungone Leeyoungone mentioned this issue Nov 19, 2021
Closed
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 19, 2021
@Leeyoungone
refactor: ensure sorted package json files
6c93903 
fixes hyperledger-cacti#1341
@petermetz
Copy link
Contributor Author

petermetz commented Nov 19, 2021 •
edited
Loading

@Leeyoungone

examples/cactus-example-carbon-accounting-backend/package.json
examples/cactus-example-carbon-accounting-business-logic-plugin/package.json
examples/cactus-example-carbon-accounting-frontend/package.json
examples/cactus-example-supply-chain-backend/package.json
examples/cactus-example-supply-chain-frontend/package.json
examples/cactus-example-supply-chain-business-logic-plugin/package.json
extensions/cactus-plugin-htlc-coordinator-besu/package.json
extensions/cactus-plugin-object-store-ipfs/package.json
packages/cactus-api-client/package.json
packages/cactus-cmd-api-server/package.json
packages/cactus-cmd-socketio-server/package.json
packages/cactus-common/package.json
packages/cactus-core/package.json
packages/cactus-core-api/package.json
packages/cactus-plugin-consortium-manual/package.json
packages/cactus-plugin-htlc-eth-besu/package.json
packages/cactus-plugin-htlc-eth-besu-erc20/package.json
packages/cactus-plugin-keychain-aws-sm/package.json
packages/cactus-plugin-keychain-azure-kv/package.json
packages/cactus-plugin-keychain-google-sm/package.json
packages/cactus-plugin-keychain-memory/package.json
packages/cactus-plugin-keychain-memory-wasm/package.json
packages/cactus-plugin-keychain-vault/package.json
packages/cactus-plugin-ledger-connector-besu/package.json
packages/cactus-plugin-ledger-connector-corda/package.json
packages/cactus-plugin-ledger-connector-fabric/package.json
packages/cactus-plugin-ledger-connector-fabric-socketio/package.json
packages/cactus-plugin-ledger-connector-go-ethereum-socketio/package.json
packages/cactus-plugin-ledger-connector-iroha/package.json
packages/cactus-plugin-ledger-connector-quorum/package.json
packages/cactus-plugin-ledger-connector-sawtooth-socketio/package.json
packages/cactus-plugin-ledger-connector-xdai/package.json
packages/cactus-plugin-odap-hermes/package.json
packages/cactus-test-api-client/package.json
packages/cactus-test-cmd-api-server/package.json
packages/cactus-test-plugin-consortium-manual/package.json
packages/cactus-test-plugin-htlc-eth-besu/package.json
packages/cactus-test-plugin-htlc-eth-besu-erc20/package.json
packages/cactus-test-plugin-ledger-connector-besu/package.json
packages/cactus-test-plugin-ledger-connector-quorum/package.json
packages/cactus-test-tooling/package.json

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 24, 2021
@Leeyoungone
ci(github): add ci build check for package json files
5ae7650 
Fixes hyperledger-cacti#1341
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 24, 2021
@Leeyoungone
ci(github): add ci build check for package json files
dd3b7d9 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@TonyRowntree
Copy link
Contributor

packages/cactus-api-client/package.json
packages/cactus-cmd-api-server/package.json
packages/cactus-common/package.json
packages/cactus-core/package.json
packages/cactus-core-api/package.json
packages/cactus-plugin-consortium-manual/package.json
packages/cactus-plugin-htlc-eth-besu/package.json
packages/cactus-plugin-htlc-eth-besu-erc20/package.json
packages/cactus-plugin-keychain-aws-sm/package.json
packages/cactus-plugin-keychain-azure-kv/package.json
packages/cactus-plugin-keychain-google-sm/package.json
packages/cactus-plugin-keychain-memory/package.json
packages/cactus-plugin-keychain-memory-wasm/package.json
packages/cactus-plugin-keychain-vault/package.json
packages/cactus-plugin-ledger-connector-besu/package.json
packages/cactus-plugin-ledger-connector-corda/package.json
packages/cactus-plugin-ledger-connector-fabric/package.json
packages/cactus-plugin-ledger-connector-fabric-socketio/package.json
packages/cactus-plugin-ledger-connector-go-ethereum-socketio/package.json
packages/cactus-plugin-ledger-connector-iroha/package.json
packages/cactus-plugin-ledger-connector-quorum/package.json
packages/cactus-plugin-ledger-connector-sawtooth-socketio/package.json
packages/cactus-plugin-ledger-connector-xdai/package.json
packages/cactus-plugin-odap-hermes/package.json
packages/cactus-test-api-client/package.json
packages/cactus-test-cmd-api-server/package.json
packages/cactus-test-plugin-consortium-manual/package.json
packages/cactus-test-plugin-htlc-eth-besu/package.json
packages/cactus-test-plugin-htlc-eth-besu-erc20/package.json
packages/cactus-test-plugin-ledger-connector-besu/package.json
packages/cactus-test-plugin-ledger-connector-quorum/package.json
packages/cactus-test-tooling/package.json
package.json
examples/cactus-example-carbon-accounting-backend/package.json
examples/cactus-example-carbon-accounting-business-logic-plugin/package.json
examples/cactus-example-carbon-accounting-frontend/package.json
examples/cactus-example-supply-chain-backend/package.json
examples/cactus-example-supply-chain-business-logic-plugin/package.json
examples/cactus-example-supply-chain-frontend/package.json
extensions/cactus-plugin-htlc-coordinator-besu/package.json
extensions/cactus-plugin-object-store-ipfs/package.json

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 6, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
91660dd 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 6, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
1e25ca2 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 7, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
2750e92 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 7, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
65a64ed 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 20, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
76647c3 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 20, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
9fd3710 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 27, 2021
@Leeyoungone
ci(json): ensure package json files are sorted
e4d9eb3 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee youngone.lee@accenture.com
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 27, 2021
@Leeyoungone
ci: ensure sorted package json files
7aa41a5 
Fixes hyperledger-cacti#1341
This was referenced Dec 29, 2021
Closed
Merged
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 14, 2022
@Leeyoungone
ci: ensure sorted package json files
3d4a687 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 14, 2022
@Leeyoungone
ci: ensure sorted package json files
f1fa6f5 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 17, 2022
@Leeyoungone
ci: ensure sorted package json files
cf8eaf9 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 19, 2022
@Leeyoungone
ci: ensure sorted package json files
0ed11d8 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 21, 2022
@Leeyoungone
ci: ensure sorted package json files
aeed4f7 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Jan 21, 2022
@Leeyoungone
ci: ensure sorted package json files
3ec1714 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Feb 2, 2022
@Leeyoungone
ci: ensure sorted package json files
f651ef1 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Feb 2, 2022
@Leeyoungone
ci: ensure sorted package json files
8b85293 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Feb 8, 2022
@Leeyoungone
ci: ensure sorted package json files
3ae2bb5 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Feb 9, 2022
@Leeyoungone
ci: ensure sorted package json files
8137d89 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Feb 25, 2022
@Leeyoungone
ci: ensure sorted package json files
988ea1c 
Fixes hyperledger-cacti#1341

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
This was referenced Mar 29, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leeyoungone Leeyoungone

Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have
Projects
None yet
Milestone
No milestone
3 participants
@petermetz @TonyRowntree @Leeyoungone