Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector-fabric): deprecate chain code compiler #1131

Closed
petermetz opened this issue Jul 13, 2021 · 1 comment · Fixed by #1638
Closed

refactor(connector-fabric): deprecate chain code compiler #1131

petermetz opened this issue Jul 13, 2021 · 1 comment · Fixed by #1638
Assignees
@petermetz
Labels
Developer_Experience Fabric good-first-issue Good for newcomers good-first-issue-100-introductory Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@petermetz
Copy link
Contributor

Description

The chain code compiler has outlived it's usefulness. Remove it from the codebase.

packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/chain-code-compiler.ts

Acceptance Criteria

  1. References in documentation are searched for and cleaned up.
  2. Test cases using it are deleted.
  3. The class itself is deleted as well.

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone
@petermetz petermetz added good-first-issue Good for newcomers Fabric Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-100-introductory labels Jul 13, 2021
@Jeff-Ushry
Copy link
Contributor

On it

@petermetz petermetz assigned petermetz and unassigned Jeff-Ushry Dec 1, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Dec 6, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
5ddcf8b 
WORK IN PROGRESS

Fixes hyperledger-cacti#1131
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
cf30441 
WORK IN PROGRESS

Fixes hyperledger-cacti#1131
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
44c6353 
Removed the chain code compiler and its related pieces of code/docs.

Also updated the Fabric connector plugin's README file to be much more
up to date.

Fixes hyperledger-cacti#1131

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Dec 8, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
2d9d5e6 
Removed the chain code compiler and its related pieces of code/docs.

Also updated the Fabric connector plugin's README file to be much more
up to date.

Fixes hyperledger-cacti#1131

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
fc03665 
Removed the chain code compiler and its related pieces of code/docs.

Also updated the Fabric connector plugin's README file to be much more
up to date.

Fixes hyperledger-cacti#1131

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Dec 10, 2021
@petermetz
refactor(connector-fabric): deprecate chain code compiler
6203d3e 
Removed the chain code compiler and its related pieces of code/docs.

Also updated the Fabric connector plugin's README file to be much more
up to date.

Fixes #1131

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Developer_Experience Fabric good-first-issue Good for newcomers good-first-issue-100-introductory Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(connector-fabric): deprecate chain code compiler petermetz/cacti
2 participants
@petermetz @Jeff-Ushry