-
Notifications
You must be signed in to change notification settings - Fork 736
Add deprecation notice #2605
Add deprecation notice #2605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the repo be marked read-only as well?
That would be a good idea, once we merge this PR. I would like a couple more eyes on what I wrote first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the anoncreds implementation, otherwise 👍 from me on marking indy-sdk as deprecated
README.md
Outdated
### [indy-shared-rs](https://github.com/hyperledger/indy-shared-rs) | ||
Contains the following shared Rust libraries for Hyperledger Indy | ||
- `indy-credx`: Indy verifiable credential issuance and presentation (aka Anoncreds). | ||
- `indy-data-types`: Data type definitions for Schemas, Credential Definitions and other types related to credential issuance and processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to the AnonCreds RS repository I think. It supports what indy-shared-rs supports + ledger agnostic anoncreds.
https://github.com/hyperledger/anoncreds-rs
This is also where the work will be happening for making AnonCreds W3C data model compliant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially if we are going to mark the repo as read-only, as @WadeBarnes and @ryjones were discussing, we should update the links as @TimoGlastra recommends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the sort of feedback I was looking for. Thanks!
c9a0be6
to
9912d71
Compare
@TimoGlastra, @dhh1128, I've replaced the |
Changes look good to me! |
7948ba2
to
527b970
Compare
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
527b970
to
7485747
Compare
LGTM |
No description provided.