Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Add deprecation notice #2605

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

WadeBarnes
Copy link
Contributor

No description provided.

Copy link
Contributor

@ryjones ryjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the repo be marked read-only as well?

@WadeBarnes
Copy link
Contributor Author

WadeBarnes commented Oct 23, 2023

Should the repo be marked read-only as well?

That would be a good idea, once we merge this PR. I would like a couple more eyes on what I wrote first.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the anoncreds implementation, otherwise 👍 from me on marking indy-sdk as deprecated

README.md Outdated
Comment on lines 13 to 16
### [indy-shared-rs](https://github.com/hyperledger/indy-shared-rs)
Contains the following shared Rust libraries for Hyperledger Indy
- `indy-credx`: Indy verifiable credential issuance and presentation (aka Anoncreds).
- `indy-data-types`: Data type definitions for Schemas, Credential Definitions and other types related to credential issuance and processing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to the AnonCreds RS repository I think. It supports what indy-shared-rs supports + ledger agnostic anoncreds.

https://github.com/hyperledger/anoncreds-rs

This is also where the work will be happening for making AnonCreds W3C data model compliant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially if we are going to mark the repo as read-only, as @WadeBarnes and @ryjones were discussing, we should update the links as @TimoGlastra recommends.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the sort of feedback I was looking for. Thanks!

@WadeBarnes
Copy link
Contributor Author

@TimoGlastra, @dhh1128, I've replaced the indy-shared-rs section with anoncreds-rs as suggested. Please have another quick look.

@TimoGlastra
Copy link
Contributor

Changes look good to me!

@WadeBarnes WadeBarnes force-pushed the deprecation-notice branch 2 times, most recently from 7948ba2 to 527b970 Compare October 24, 2023 13:11
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@dhh1128
Copy link
Contributor

dhh1128 commented Oct 24, 2023

LGTM

@WadeBarnes WadeBarnes merged commit 2d47f2f into hyperledger-archives:main Oct 24, 2023
21 of 23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants