Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Provide the way to configure logging on C API level #22

Closed
vimmerru opened this issue May 30, 2017 · 5 comments
Closed

Provide the way to configure logging on C API level #22

vimmerru opened this issue May 30, 2017 · 5 comments

Comments

@vimmerru
Copy link

Currently, libsovrin uses popular https://github.com/rust-lang-nursery/log facade. It allows linking with logger implementation in runtime.

We use env_logger that allows logging configuration by environment variables for our tests, but there is no logger initialization provided on C API level. I suggest the following:

  1. Call env_logger init method during initialization of CommandExecutor singleton
  2. Provide API that will allow registering custom callbacks for the logger. It will allow re-using same logging infrastructure as the main application that uses libsovrin.

Point 2 can be postponed.

@dhh1128
Copy link
Contributor

dhh1128 commented May 30, 2017

I am happy with this approach.

@peacekeeper
Copy link
Contributor

Sounds good.

@vimmerru
Copy link
Author

Call env_logger init method during initialization of CommandExecutor singleton

It is already merged.

Currently, the library activates trace by default at info level for all modules.
This behavior can be changed by setting environment variable RUST_LOG.

RUST_LOG=<module>=<log_level>[,<module>=<log_level>]*

E.g. RUST_LOG=sovrin=trace,zmq=debug (edited)

jovfer pushed a commit that referenced this issue Aug 7, 2017
Merging master from hyperledger
@lodo1995
Copy link
Contributor

lodo1995 commented May 2, 2018

@vimmerru is there any progress on point 2? I would really like to be able to intercept log calls of libindy and handle them in a custom way.

dkulic pushed a commit to dkulic/indy-sdk that referenced this issue Aug 14, 2018
…ves#22)

* When node's garbage collection is triggered, a callback in clearOnExit
will be called which calls release on the Rust connection object.
Garbage collection should happen with our sdk when garbage collection
happens with node.
Improved Tests

* added comments for the clearOnExit

* Removed the list_state function in connection object because it isn't
implemented in Rust yet.

* fixed connection tests and Connection Interface

* changed vars to camel case. Changed docker file to update npm

* deleted js files in src directory

* changed test because of naming conflicts

* fixed path for one of the imports

* changed tsconfig

* added dist directory. This will be temporary

* added weak library to package.json

* Corrected the test format for index-test.js
Removed the references to cxs_connection_list_state because we aren't using it yet
Fixed paths in connection-test

* added js files from dist. Won't have in the future

* Removed the dist directory from github

Signed-off-by: ryMarsh44 <ryan.marsh44@gmail.com>
@jovfer
Copy link
Contributor

jovfer commented Aug 31, 2018

@jovfer jovfer closed this as completed Aug 31, 2018
Artemkaaas pushed a commit to Artemkaaas/indy-sdk that referenced this issue Jun 22, 2020
* initial commit to get help debugging

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Fixed to use detached

Signed-off-by: Michael Lodder <redmike7@gmail.com>

* PoC of pack and unpack with JWEs working

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional pack and unpack tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* updated tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* tests running with command layer added

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed types in APIs

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* finished unpack api

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* removed microledger work from branch

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* "removed forward functionality for this PR"

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed compilation warnings

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* remove route table functionality - moving to separate PR

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* aligning code current HIPE descriptions

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkpoint commit not compiling

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - compiles but needs testing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin compiling but test fail

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit cargo test not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* rustfmt code; fixed first test; needs further updates to unpack return data

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* changed dependencies to fix warnings

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactor additional texts

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fix rebase mistakes - all tests passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added vscode to gitignore

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added python wrapper

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactors to align HIPE in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactors to align HIPE in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* intermediate checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed cargo files - not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactored API layer

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit refactor in progress and not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed tests - all passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* HIPE alignment refactor in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit command layer work

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin command layer WIP

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added detached with aad functons

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactored encrypt_plaintext and decrypt_ciphertext to use detached functionality now

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* needs c headers and tests - but compiles code upto API layer

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* build properly - pack_message test throws segfault

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed seg fault issue first test passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added high level tests for pack_message

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* initial commit to get help debugging

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Fixed to use detached

Signed-off-by: Michael Lodder <redmike7@gmail.com>

* PoC of pack and unpack with JWEs working

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional pack and unpack tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* updated tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* tests running with command layer added

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed types in APIs

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* finished unpack api

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* "removed forward functionality for this PR"

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed compilation warnings

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* remove route table functionality - moving to separate PR

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* aligning code current HIPE descriptions

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkpoint commit not compiling

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - compiles but needs testing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin compiling but test fail

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit cargo test not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* rustfmt code; fixed first test; needs further updates to unpack return data

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* changed dependencies to fix warnings

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactor additional texts

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fix rebase mistakes - all tests passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added vscode to gitignore

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added python wrapper

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactors to align HIPE in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactors to align HIPE in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* intermediate checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed cargo files - not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactored API layer

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit refactor in progress and not building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit - building

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed tests - all passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* HIPE alignment refactor in progress

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin commit command layer work

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* checkin command layer WIP

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added detached with aad functons

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* refactored encrypt_plaintext and decrypt_ciphertext to use detached functionality now

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* needs c headers and tests - but compiles code upto API layer

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* build properly - pack_message test throws segfault

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed seg fault issue first test passing

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added high level tests for pack_message

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added additional tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added python pack message api

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added python wrapper tests (WIP)

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* start sdk architecture overview doc

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* changed from message pack encoding to base64 encoding

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* updated cargo.lock

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Sync rebase and origin history

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* refactored encoding to support both message_pack and base64

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added deprecate message to API

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* non-building checkin commit need to fix zeroize trait for chacha key

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed changes that were started for zeroize - key_mem happens in sodiumoxide

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* change nonce to iv for pack/unpack

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* changed to reflect ietf implementation

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added basicmessage message family format to tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fix to use null opt_c_str macro

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fix base64 changes

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fixed encode and decode tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* jovfer code review comment updates

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* removed sdk architecture docs - they're available on a separate branch PR

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* push python wrapper updates

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* fix header to use u32 instead of u64

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* remove python wrapper - move to separate PR

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* remove "C" from API layer

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* update cargo.lock

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* added recipient_key value to unpack return val

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* updated comments to show proper format

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Slightly reorganize pack command layer.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Minor cleanup.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Fix merge issues.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Cleanup route.rs.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Fix integration tests for pack/unpack

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Clean-up API description

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* Move pack/unpack into crypto module for python wrapper.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-company.com>

* Add missed experimental for new API.

Signed-off-by: Sergey Minaev <sergey.minaev@dsr-corporation.com>

* filter payment addresses based on configured payment method

Signed-off-by: Douglas Wightman <douglas.wightman@evernym.com>

* fix indentation

Signed-off-by: Douglas Wightman <douglas.wightman@evernym.com>

* IS-1160 following the pattern of authCrypt

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* IS-1160 removed commented out line

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* updated readme

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* add log statement when address isn't compatible

Signed-off-by: Douglas Wightman <douglas.wightman@evernym.com>

* finishes tests

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* added more tests

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* added a few more tests, renamed misnamed tests

Signed-off-by: matt raffel <matt.raffel@evernym.com>

* fixes agency push notification for a cred offer

Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>

* update python wrapper

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Add pack and unpack message wrappers. Unit tests.

Signed-off-by: Tomislav Markovski <tmarkovski@gmail.com>

* Updated NodeJS wrapper to support Pack/Unpack functions

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>

* added additional tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Updated objective-c wrapper to support Pack/Unpack functions

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>

* added additional pack and unpack tests

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* making changes based on feedback from comments

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* more updates based on comments

Signed-off-by: Kyle Den Hartog <kdenhar@gmail.com>

* Code refactoring and fixed some mistakes related to Pack/Unpack function in Java.

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>

* Little update of documentation

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>

* Python wrapper fixes. Added key validation to pack function

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>

* Changed type of returning value for python unpack_message function

Signed-off-by: artem.ivanov <artem.ivanov@dsr-company.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants