This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Sanitise dependencies #3798
Merged
Sanitise dependencies #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone1
reviewed
Apr 13, 2018
| "dependencies": { | ||
| "composer-common": "0.19.1", |
There was a problem hiding this comment.
Why is not in devDependencies like the other ones?
sstone1
reviewed
Apr 13, 2018
| "dependencies": { | ||
| "composer-common": "0.19.1", |
There was a problem hiding this comment.
Why is not in devDependencies like the other ones?
sstone1
reviewed
Apr 13, 2018
| "dependencies": { | ||
| "composer-common": "0.19.1", |
There was a problem hiding this comment.
Why is not in devDependencies like the other ones?
|
@sstone1 |
mbwhite
force-pushed
the
sanitise-dependencies
branch
from
8158a53
to
e149806
Compare
|
This doesn't build @mbwhite! |
|
@sstone1 not yet no... |
mbwhite
force-pushed
the
sanitise-dependencies
branch
2 times, most recently
from
103f89d
to
06aef7d
Compare
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
sanitise-dependencies
branch
from
06aef7d
to
438f28a
Compare
|
Build works on my own travis org... https://travis-ci.org/mbwhite/composer/builds/371939672 |
jt-nti
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce peerDependencies for a number of core modules to reduce the size of them.
part resolves #3795