This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
perf: remove extra parsing #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
- Coverage 87.76% 87.76% -0.01%
==========================================
Files 351 351
Lines 48636 48627 -9
==========================================
- Hits 42685 42677 -8
+ Misses 4403 4402 -1
Partials 1548 1548
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Apr 25, 2023
skynet2
force-pushed
the
perf-remove-extraparse
branch
from
f55f41d to
a4bbc12
Compare
sandrask
approved these changes
Apr 25, 2023
skynet2
force-pushed
the
perf-remove-extraparse
branch
2 times, most recently
from
6d51a58 to
33fe70b
Compare
Moopli
pushed a commit
to Moopli/aries-framework-go
that referenced
this pull request
Apr 25, 2023
* perf: remove extra parsing * fix: lint * perf: avoid one more perse
Moopli
pushed a commit
to Moopli/aries-framework-go
that referenced
this pull request
Apr 25, 2023
* perf: remove extra parsing * fix: lint * perf: avoid one more perse
sudeshrshetty
pushed a commit
that referenced
this pull request
Apr 25, 2023
Moopli
added a commit
to Moopli/aries-framework-go
that referenced
this pull request
Apr 25, 2023
sudeshrshetty
added a commit
that referenced
this pull request
Apr 25, 2023
sudeshrshetty
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifySignature does not require parsed claims to do that functionality. we already parsing claims in many other places.
