Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: Match submission requirements not apply limited disclosure. #3559

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Apr 19, 2023

Title:

MatchSubmissionRequirement no longer applies limited disclosure on its results, now it just filters applicable credentials.

Summary:

Functionality that applies limited disclosure was factored from filterConstraints to separate function limitDisclosure.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #3559 (ed2d845) into main (344a7f8) will decrease coverage by 0.01%.
The diff coverage is 95.08%.

@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
- Coverage   87.76%   87.75%   -0.01%     
==========================================
  Files         351      351              
  Lines       48612    48646      +34     
==========================================
+ Hits        42662    42689      +27     
- Misses       4402     4407       +5     
- Partials     1548     1550       +2     
Impacted Files Coverage Δ
pkg/doc/presexch/definition.go 85.32% <95.08%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vkubiv vkubiv force-pushed the fix-get-submission-requirements branch from 99ac8ff to 635fbc4 Compare April 19, 2023 12:30
…n credentials.

Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the fix-get-submission-requirements branch from 635fbc4 to ed2d845 Compare April 19, 2023 12:56
@sudeshrshetty sudeshrshetty merged commit 69e0be0 into hyperledger-archives:main Apr 19, 2023
@vkubiv vkubiv deleted the fix-get-submission-requirements branch April 19, 2023 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants