-
Notifications
You must be signed in to change notification settings - Fork 160
refactor: move crypto/kms APIs to spi module. #3558
refactor: move crypto/kms APIs to spi module. #3558
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
+ Coverage 87.71% 87.75% +0.04%
==========================================
Files 352 351 -1
Lines 48638 48612 -26
==========================================
- Hits 42662 42659 -3
+ Misses 4428 4404 -24
- Partials 1548 1549 +1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/kms" | ||
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/kms/localkms/internal/keywrapper" | ||
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/secretlock" | ||
kms2 "github.com/hyperledger/aries-framework-go/spi/kms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to rename km2
to something else more descriptive, perhaps spikms
(same comment applies to other places in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment
Also includes some cleanup refactoring in component/kmscrypto. Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
1e1eeae
to
d9f6d8e
Compare
Also includes some cleanup refactoring in component/kmscrypto.