Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

refactor: move crypto/kms APIs to spi module. #3558

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Apr 14, 2023

Also includes some cleanup refactoring in component/kmscrypto.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3558 (d9f6d8e) into main (6013a6b) will increase coverage by 0.04%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
+ Coverage   87.71%   87.75%   +0.04%     
==========================================
  Files         352      351       -1     
  Lines       48638    48612      -26     
==========================================
- Hits        42662    42659       -3     
+ Misses       4428     4404      -24     
- Partials     1548     1549       +1     
Impacted Files Coverage Δ
...to/crypto/primitive/bbs12381g2pub/bbs12381g2pub.go 87.09% <ø> (ø)
...ent/kmscrypto/crypto/primitive/bbs12381g2pub/fr.go 100.00% <ø> (ø)
...t/kmscrypto/crypto/primitive/bbs12381g2pub/keys.go 85.60% <ø> (ø)
...ypto/primitive/bbs12381g2pub/proof_of_knowledge.go 98.07% <ø> (ø)
...crypto/crypto/primitive/bbs12381g2pub/signature.go 100.00% <ø> (ø)
...rypto/primitive/bbs12381g2pub/signature_message.go 100.00% <ø> (ø)
.../crypto/primitive/bbs12381g2pub/signature_proof.go 84.04% <ø> (ø)
.../kmscrypto/crypto/primitive/bbs12381g2pub/utils.go 100.00% <ø> (ø)
...nent/kmscrypto/crypto/tinkcrypto/cl_crypto_stub.go 100.00% <ø> (ø)
...mponent/kmscrypto/crypto/tinkcrypto/key_wrapper.go 82.89% <ø> (ø)
... and 67 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Moopli Moopli marked this pull request as ready for review April 14, 2023 23:50
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/kms"
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/kms/localkms/internal/keywrapper"
"github.com/hyperledger/aries-framework-go/component/kmscrypto/pkg/secretlock"
kms2 "github.com/hyperledger/aries-framework-go/spi/kms"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to rename km2 to something else more descriptive, perhaps spikms (same comment applies to other places in this PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Contributor

@DRK3 DRK3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

Also includes some cleanup refactoring in component/kmscrypto.

Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
@Moopli Moopli force-pushed the kmscrypto-module branch from 1e1eeae to d9f6d8e Compare April 17, 2023 17:48
@rolsonquadras rolsonquadras requested a review from DRK3 April 17, 2023 17:49
@sudeshrshetty sudeshrshetty merged commit 344a7f8 into hyperledger-archives:main Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants