Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: refactor logs and kms+crypto into separate components #3557

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Apr 6, 2023

  • component/log: Logging API implementation.
  • component/kmscrypto: KMS, Crypto, and some JWK APIs, and their
    implementations.

For refactored APIs, the original APIs have been left in their
original locations, transparently referencing/wrapping
the new APIs, to minimize breaking changes for consumers of
these APIs. Exceptions are:

  • KMS protobufs for key data don't have wrappers in their original
    locations. Imports need to be amended to component/kmscrypto.

Once further refactoring is complete, these original APIs will be
deprecated and callers advised to use the refactored APIs instead.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #3557 (b22b813) into main (e4ab333) will decrease coverage by 0.02%.
The diff coverage is 86.31%.

@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
- Coverage   87.73%   87.71%   -0.02%     
==========================================
  Files         351      352       +1     
  Lines       48577    48638      +61     
==========================================
+ Hits        42618    42662      +44     
- Misses       4414     4428      +14     
- Partials     1545     1548       +3     
Impacted Files Coverage Δ
component/kmscrypto/pkg/crypto/eckey.go 100.00% <ø> (ø)
...kmscrypto/pkg/crypto/primitive/bbs12381g2pub/fr.go 100.00% <ø> (ø)
...crypto/pkg/crypto/primitive/bbs12381g2pub/utils.go 100.00% <ø> (ø)
.../kmscrypto/pkg/crypto/tinkcrypto/cl_crypto_stub.go 100.00% <ø> (ø)
...omponent/kmscrypto/pkg/crypto/tinkcrypto/crypto.go 88.50% <ø> (ø)
...ent/kmscrypto/pkg/crypto/tinkcrypto/key_wrapper.go 82.89% <ø> (ø)
...to/primitive/aead/aes_cbc_hmac_aead_key_manager.go 90.74% <ø> (ø)
...tinkcrypto/primitive/bbs/bbs_signer_key_manager.go 83.46% <ø> (ø)
...nkcrypto/primitive/bbs/bbs_verifier_key_manager.go 100.00% <ø> (ø)
...composite/ecdh/ecdh_nistpkw_private_key_manager.go 90.07% <ø> (ø)
... and 76 more

... and 38 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Moopli Moopli force-pushed the kmscrypto-module branch 3 times, most recently from c639e96 to 07f842d Compare April 6, 2023 17:04
- component/log: Logging API implementation.
- component/kmscrypto: KMS, Crypto, and some JWK APIs, and their
  implementations.

For refactored APIs, the original APIs have been left in their
original locations, transparently referencing/wrapping
the new APIs, to minimize breaking changes for consumers of
these APIs. Exceptions are:
- KMS protobufs for key data don't have wrappers in their original
  locations. Imports need to be amended to component/kmscrypto.

Once further refactoring is complete, these original APIs will be
deprecated and callers advised to use the refactored APIs instead.

Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
@Moopli Moopli force-pushed the kmscrypto-module branch from 07f842d to b22b813 Compare April 6, 2023 18:14
@Moopli Moopli marked this pull request as ready for review April 6, 2023 23:56
@rolsonquadras rolsonquadras requested a review from vkubiv April 10, 2023 13:52
@sudeshrshetty sudeshrshetty merged commit 6013a6b into hyperledger-archives:main Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants