Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: PresentationDefinition API improvements: #3547

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Mar 7, 2023

  • CreateVP methods set VP IDs
  • Match supports merged submission map[string]interface{} and VP submission fields of PresentationSubmission type.

- CreateVP methods set VP IDs
- Match supports merged submission map[string]interface{} and
  VP submission fields of PresentationSubmission type.

Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
@Moopli Moopli requested a review from sandrask March 7, 2023 17:19
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3547 (719380f) into main (175d658) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   87.75%   87.74%   -0.02%     
==========================================
  Files         351      351              
  Lines       48511    48571      +60     
==========================================
+ Hits        42573    42620      +47     
- Misses       4398     4408      +10     
- Partials     1540     1543       +3     
Impacted Files Coverage Δ
pkg/internal/ldtestutil/document_loader.go 82.14% <ø> (ø)
pkg/doc/presexch/api.go 87.92% <72.00%> (-1.83%) ⬇️
pkg/doc/presexch/definition.go 85.42% <86.66%> (-0.43%) ⬇️
pkg/doc/verifiable/credential.go 91.04% <100.00%> (+0.04%) ⬆️
.../tinkcrypto/primitive/secp256k1/subtle/encoding.go 61.01% <0.00%> (+5.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sudeshrshetty sudeshrshetty merged commit 8771727 into hyperledger-archives:main Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants