Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Add BDD test for legacy-connection protocol #3353

Conversation

Abdulbois
Copy link
Contributor

@Abdulbois Abdulbois commented Aug 29, 2022

Title:
Add BDD test for legacy-connection protocol

Summary:

  • Add BDD test for legacy-connection protocol. Edge to edge case is fully implemented. Case through mediator is implemented partially (Only steps are added. Need to add .feature file to run test)
  • Make a few refactoring

Related to #3301

@Abdulbois Abdulbois force-pushed the bdd-tests-for-legacy-connection branch from 0feec70 to 26b563c Compare August 29, 2022 11:13
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3353 (06a3088) into main (a66828f) will decrease coverage by 0.05%.
The diff coverage is 61.95%.

@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   87.89%   87.84%   -0.06%     
==========================================
  Files         330      330              
  Lines       45571    45633      +62     
==========================================
+ Hits        40056    40087      +31     
- Misses       4085     4110      +25     
- Partials     1430     1436       +6     
Impacted Files Coverage Δ
pkg/didcomm/protocol/legacyconnection/service.go 86.74% <ø> (-0.08%) ⬇️
pkg/doc/presexch/definition.go 83.26% <59.77%> (-3.08%) ⬇️
pkg/didcomm/protocol/legacyconnection/states.go 87.20% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…gh controller). Make a few refactoring

- Add BDD test for legacy-connection protocol. Edge to edge case is fully implemented. Case through mediator is implemented partially (Only steps are added. Need to add .feature file to run test)
- Make a few refactoring

Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
@Abdulbois Abdulbois force-pushed the bdd-tests-for-legacy-connection branch from 26b563c to 5770ad2 Compare August 29, 2022 11:56
@Abdulbois Abdulbois closed this Aug 29, 2022
@Abdulbois Abdulbois reopened this Aug 29, 2022
@sudeshrshetty sudeshrshetty merged commit b1decdf into hyperledger-archives:main Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants