Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: CL Anoncreds Remote KMS/Crypto #3343

Merged

Conversation

kgoncharov
Copy link
Contributor

Title:
CL Anoncreds Remote KMS/Crypto

Description:

  • Fifth PR to support CL in af-go #180
  • This PR implements/supports CL methods in remote Crypto
  • This PR adds support for KMS extension for remote KMS
  • "server"-side changes will be implemented in the separate PR in both trustbloc/kms

Summary:

  • added client calls to CL methods in remote crypto
  • added attrs propagation for remote kms
  • added unit tests for remote kms/crypto
  • added more failed cases for localkms ursa tests

* added client calls to CL methods in remote crypto
* added attrs propagation for remote kms
* added unit tests for remote kms/crypto
* added more failed cases for localkms ursa tests

Signed-off-by: konstantin.goncharov <konstantin.goncharov@avast.com>
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #3343 (8eacdba) into main (730ac30) will decrease coverage by 0.09%.
The diff coverage is 53.04%.

@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
- Coverage   87.99%   87.90%   -0.10%     
==========================================
  Files         328      328              
  Lines       45231    45336     +105     
==========================================
+ Hits        39803    39854      +51     
- Misses       4012     4061      +49     
- Partials     1416     1421       +5     
Impacted Files Coverage Δ
pkg/crypto/webkms/remotecrypto.go 83.38% <50.00%> (-7.65%) ⬇️
pkg/kms/webkms/remotekms.go 94.13% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@baha-ai baha-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I like the matchPath() enhancement

@sudeshrshetty sudeshrshetty merged commit 77fbef7 into hyperledger-archives:main Aug 22, 2022
@kgoncharov kgoncharov deleted the cl-remote-kms-crypto branch August 26, 2022 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants