This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
refactor: A few refactoring of legacy-connection package #3342
Merged
fqutishat
merged 2 commits into
hyperledger-archives:main
from
Abdulbois:legacy-connection-refactor
Aug 25, 2022
Merged
refactor: A few refactoring of legacy-connection package #3342
fqutishat
merged 2 commits into
hyperledger-archives:main
from
Abdulbois:legacy-connection-refactor
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3342 +/- ##
==========================================
- Coverage 87.90% 87.89% -0.01%
==========================================
Files 328 330 +2
Lines 45336 45498 +162
==========================================
+ Hits 39854 39992 +138
- Misses 4061 4079 +18
- Partials 1421 1427 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
2 times, most recently
from
August 18, 2022 15:19
b5406b0
to
117ca57
Compare
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
from
August 18, 2022 15:31
117ca57
to
039d03d
Compare
Are we planning to write an integration acceptance test in af-go that will check the interoperability between af-go legacy connection protocol and other implementations (VCX in particular)? Will a BDD test do these checks? Or we need another one? |
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
3 times, most recently
from
August 19, 2022 12:07
5f2040f
to
047e747
Compare
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
2 times, most recently
from
August 22, 2022 06:38
27871db
to
83cf255
Compare
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
2 times, most recently
from
August 22, 2022 06:50
38ceb3e
to
07cf93f
Compare
- Add new legacy http header to handle legacy requests. Cover with unit tests - Encode invitation Recipient key to base58 - Change embedded verification to referenced while creating verification methods - Add legacy file into doc package to convert DIDdoc to raw doc. Cover with unit test - Add handling DID id's where did method is not specified - Add JSONBytes and ParseConnection methods to use them while handling connection data - Change AckMsgType content to proper one - Add method to convert array of did-keys to base58 keys - Enable saving decryption key while handling envelope at connection-request state - Add new InvitationRecipientKeys into connection.Record model - Refactor requestMsgRecord, handleInboundRequest and prepareConnectionSignature methods and their unit-tests - Save Recipient keys while handling connection request - Use SaveDID instead SaveDIDByResolving Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Abdulbois
force-pushed
the
legacy-connection-refactor
branch
from
August 22, 2022 11:45
07cf93f
to
df96a1c
Compare
sudeshrshetty
approved these changes
Aug 22, 2022
ashcherbakov
approved these changes
Aug 22, 2022
baha-ai
approved these changes
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Refactor legacy-connection package due to interoperability issues
Summary: