This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
test/support ability in AFGO to create and parse vc and vp in JWT format #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishasizov-SK
commented
Aug 15, 2022
| Verifier: getVerifier(resolver, VerifyRS256), | ||
| }, | ||
| ) | ||
| verifiers := []verifier.SignatureVerifier{ |
There was a problem hiding this comment.
Extended the list of default verifiers.
mishasizov-SK
commented
Aug 15, 2022
Comment on lines
-505
to
-541
|
|
||
| type docLoaderProvider struct { | ||
| ContextStore ldstore.ContextStore | ||
| RemoteProviderStore ldstore.RemoteProviderStore | ||
| } | ||
|
|
||
| func (p *docLoaderProvider) JSONLDContextStore() ldstore.ContextStore { | ||
| return p.ContextStore | ||
| } | ||
|
|
||
| func (p *docLoaderProvider) JSONLDRemoteProviderStore() ldstore.RemoteProviderStore { | ||
| return p.RemoteProviderStore | ||
| } | ||
|
|
||
| func createDocumentLoader() (*ld.DocumentLoader, error) { | ||
| contextStore, err := ldstore.NewContextStore(mem.NewProvider()) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| remoteProviderStore, err := ldstore.NewRemoteProviderStore(mem.NewProvider()) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| p := &docLoaderProvider{ | ||
| ContextStore: contextStore, | ||
| RemoteProviderStore: remoteProviderStore, | ||
| } | ||
|
|
||
| loader, err := ld.NewDocumentLoader(p, ld.WithExtraContexts(bddldcontext.Extra()...)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return loader, nil | ||
| } |
There was a problem hiding this comment.
reused the code from github.com/hyperledger/aries-framework-go/test/bdd/pkg/verifiable
Codecov Report
@@ Coverage Diff @@
## main #3334 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 323 323
Lines 44437 44445 +8
=======================================
+ Hits 39110 39118 +8
Misses 3929 3929
Partials 1398 1398
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
reviewed
Aug 15, 2022
test/bdd/features/jwt.feature
Outdated
| Feature: Issue and verify Verifiable Credential and Verifiable Presentation with JWS proof | ||
| @issue_vc_vp_jwt_ed25519 | ||
| Scenario: Issue VC - verify VC - create VP - verify VP with Ed25519 JWS proof | ||
| When "Berkley" issues VC at "2022-04-12" regarding "Master Degree" to "Alice" with "Ed25519" JWS proof |
There was a problem hiding this comment.
Change from JWS proof to JWS format
There was a problem hiding this comment.
changed, pls see
fqutishat
reviewed
Aug 15, 2022
test/bdd/features/jwt.feature
Outdated
| Then "Alice" embeds the VC into VP with "Ed25519" JWS proof | ||
| Then "Alice" verifies VP | ||
|
|
||
| @issue_vc_vp_jwt_ecdsaSecp256r1 |
There was a problem hiding this comment.
No need to duplicate steps you can use something like this https://github.com/hyperledger/aries-framework-go/blob/main/test/bdd/features/didexchange_public_did.feature#L67
There was a problem hiding this comment.
great catch! updated
Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>
mishasizov-SK
force-pushed
the
test/create-parse-vp-vc-jwt
branch
from
7f60a99 to
046adf0
Compare
fqutishat
approved these changes
Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykhailo Sizov mykhailo.sizov@securekey.com
Title:
Support ability in AFGO to create and parse vc and vp in JWT format
Description:
Added BDD tests with creating and verifying VC and VP in JWT format.
Solves: #3314
Summary:
Algorithms included: