This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix: vc subject marshal #3324
Merged
fix: vc subject marshal #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baha-ai
approved these changes
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #3324 +/- ##
==========================================
- Coverage 88.01% 88.00% -0.01%
==========================================
Files 322 322
Lines 44396 44389 -7
==========================================
- Hits 39073 39066 -7
Misses 3927 3927
Partials 1396 1396
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
baha-ai
approved these changes
Aug 10, 2022
troyronda
approved these changes
Aug 10, 2022
| @@ -739,10 +734,7 @@ func parseSubject(subjectBytes json.RawMessage) ([]Subject, error) { | |||
|
|
|||
| err := json.Unmarshal(subjectBytes, &subjectID) | |||
| if err == nil { | |||
There was a problem hiding this comment.
this might break JSON LD VCs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com