Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: JWS algorithm for signature suite #3322

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

fqutishat
Copy link
Contributor

@fqutishat fqutishat commented Aug 10, 2022

Signed-off-by: Firas Qutishat firas.qutishat@securekey.com

closes #1589

@fqutishat fqutishat changed the title fix: add EdDSA header for JsonWebSignature2020 fix: JWS algorithm for signature suite Aug 10, 2022
@fqutishat fqutishat force-pushed the updatye branch 8 times, most recently from 529fd46 to 1698ae6 Compare August 10, 2022 11:57
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #3322 (1b2da77) into main (6c0753b) will decrease coverage by 0.03%.
The diff coverage is 52.50%.

@@            Coverage Diff             @@
##             main    #3322      +/-   ##
==========================================
- Coverage   88.04%   88.01%   -0.04%     
==========================================
  Files         322      322              
  Lines       44381    44396      +15     
==========================================
- Hits        39077    39073       -4     
- Misses       3908     3927      +19     
  Partials     1396     1396              
Impacted Files Coverage Δ
pkg/client/issuecredential/rfc0593/dependencies.go 100.00% <ø> (ø)
pkg/client/issuecredential/rfc0593/event.go 68.33% <0.00%> (-0.37%) ⬇️
...mm/protocol/middleware/presentproof/middlewares.go 87.14% <0.00%> (-0.55%) ⬇️
pkg/doc/signature/suite/suite.go 93.54% <0.00%> (-6.46%) ⬇️
pkg/doc/signature/suite/suite_crypto.go 86.66% <0.00%> (-13.34%) ⬇️
...oc/util/signature/internal/signer/crypto_signer.go 95.77% <0.00%> (-4.23%) ⬇️
pkg/doc/util/signature/internal/signer/ed25519.go 52.63% <0.00%> (-6.20%) ⬇️
pkg/doc/verifiable/jws.go 79.54% <ø> (ø)
pkg/doc/util/signature/internal/signer/rsa.go 73.07% <33.33%> (-6.09%) ⬇️
pkg/doc/util/signature/internal/signer/ecdsa.go 61.70% <83.33%> (-0.94%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

closes hyperledger-archives#1589

Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
@fqutishat fqutishat merged commit dd90d1d into hyperledger-archives:main Aug 10, 2022
@fqutishat fqutishat deleted the updatye branch August 10, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

JWS algorithm for signature suite
3 participants