This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix: presentation with empty credential fix #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes how a presentation is marshalled with empty credential field which wrongly outputs: '"verifiableCredential": null' This change skips this field if the presentation Credential field is empty Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com>
baha-ai
force-pushed
the
presentation_cred_nil_fix
branch
from
fcd1c62 to
d84c044
Compare
Codecov Report
@@ Coverage Diff @@
## main #3319 +/- ##
=======================================
Coverage 88.05% 88.05%
=======================================
Files 318 318
Lines 43152 43156 +4
=======================================
+ Hits 37998 38002 +4
Misses 3799 3799
Partials 1355 1355
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes how a presentation is marshalled with empty credential field which wrongly outputs:
'"verifiableCredential": null'
This change skips this field if the presentation Credential field is empty
Signed-off-by: Baha Shaaban baha.shaaban@securekey.com