Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Add RemoveCredentialByName to aries js helpers #3318

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

borancar
Copy link
Contributor

@borancar borancar commented Aug 8, 2022

Function was available in the core but was missing from the JavaScript
wrapper.

Signed-off-by: Boran Car boran.car@gmail.com

@borancar
Copy link
Contributor Author

borancar commented Aug 8, 2022

A quick search also shows RemovePresentation variants missing, but I guess these are better handled as one-by-one?

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #3318 (b7fe2ee) into main (730ac30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3318   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         328      328           
  Lines       45231    45231           
=======================================
  Hits        39803    39803           
  Misses       4012     4012           
  Partials     1416     1416           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@sudeshrshetty sudeshrshetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please rebase your PR.

@borancar borancar requested a review from sudeshrshetty August 11, 2022 13:34
@borancar borancar changed the title Add RemoveCredentialByName to aries.js Add RemoveCredentialByName to aries js helpers Aug 11, 2022
@borancar borancar force-pushed the main branch 2 times, most recently from 86ca474 to 993df65 Compare August 15, 2022 16:25
Function was available in the core but was missing from the JavaScript
wrappers.

Signed-off-by: Boran Car <boran.car@gmail.com>
@fqutishat fqutishat merged commit 76c8467 into hyperledger-archives:main Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants