This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
refactor: credential manifest enhancements to match wallet-rendering specs #3309
Merged
sudeshrshetty
merged 1 commit into
hyperledger-archives:main
from
HeidiHan0000:credential-manifest-enhancements
Aug 2, 2022
Merged
refactor: credential manifest enhancements to match wallet-rendering specs #3309
sudeshrshetty
merged 1 commit into
hyperledger-archives:main
from
HeidiHan0000:credential-manifest-enhancements
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeidiHan0000
force-pushed
the
credential-manifest-enhancements
branch
from
July 29, 2022 18:28
6fa3083
to
827d786
Compare
Codecov Report
@@ Coverage Diff @@
## main #3309 +/- ##
=======================================
Coverage 88.18% 88.19%
=======================================
Files 317 318 +1
Lines 42945 42967 +22
=======================================
+ Hits 37872 37894 +22
Misses 3727 3727
Partials 1346 1346
Help us with your feedback. Take ten seconds to tell us how you rate us. |
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
reviewed
Aug 2, 2022
DRK3
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor grammar comments. I don't see any code issues. The comments I left were all on code that you just moved from somewhere else rather than new code, so it's up to you if you think it's worth fixing!
@DRK3 I'll make those grammar changes, thanks for reviewing! |
HeidiHan0000
force-pushed
the
credential-manifest-enhancements
branch
from
August 2, 2022 16:24
827d786
to
48c284c
Compare
@sudeshrshetty Could you please approve the CI tests again? |
sudeshrshetty
approved these changes
Aug 2, 2022
HeidiHan0000
force-pushed
the
credential-manifest-enhancements
branch
2 times, most recently
from
August 2, 2022 19:29
56743d2
to
48c284c
Compare
…specs Signed-off-by: heidihan0000 <daeun.han@avast.com>
HeidiHan0000
force-pushed
the
credential-manifest-enhancements
branch
from
August 2, 2022 19:34
8ac5149
to
729f5e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #3304
Closes #3274
Closes #3280
Closes #3281