This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Remove warning from secret lock and update documentation #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a warning that would happen if trying to read in a master key using raw bytes, as this is actually a normal scenario. Also updated some related documentation to make it more clear that raw byte master keys are an expected use case. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
SecretLockRemoveWarning
branch
from
3c6b9b3 to
1f4f865
Compare
Codecov Report
@@ Coverage Diff @@
## main #3307 +/- ##
==========================================
- Coverage 88.18% 88.18% -0.01%
==========================================
Files 317 317
Lines 42946 42945 -1
==========================================
- Hits 37873 37869 -4
- Misses 3727 3729 +2
- Partials 1346 1347 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
baha-ai
approved these changes
Jul 28, 2022
fqutishat
approved these changes
Jul 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a warning that would happen if trying to read in a master key using raw bytes, as this is actually a normal scenario. Also updated some related documentation to make it more clear that raw byte master keys are an expected use case.
Signed-off-by: Derek Trider Derek.Trider@securekey.com