This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Feat split wallet command #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkubiv
force-pushed
the
feat-split-wallet-command
branch
from
3b9b61c to
0795da1
Compare
Codecov Report
@@ Coverage Diff @@
## main #3276 +/- ##
=======================================
Coverage ? 88.18%
=======================================
Files ? 317
Lines ? 42946
Branches ? 0
=======================================
Hits ? 37873
Misses ? 3727
Partials ? 1346
Help us with your feedback. Take ten seconds to tell us how you rate us. |
vkubiv
force-pushed
the
feat-split-wallet-command
branch
from
0795da1 to
f680d63
Compare
vkubiv
force-pushed
the
feat-split-wallet-command
branch
from
891e0e3 to
a24b620
Compare
fqutishat
approved these changes
Jul 25, 2022
sudeshrshetty
suggested changes
Jul 26, 2022
There was a problem hiding this comment.
@vkubiv please make changes as discussed.
vcwallet, didcommwallet
vkubiv
force-pushed
the
feat-split-wallet-command
branch
from
a24b620 to
ec13ace
Compare
sudeshrshetty
suggested changes
Jul 26, 2022
vkubiv
force-pushed
the
feat-split-wallet-command
branch
2 times, most recently
from
c16e4bd to
f094059
Compare
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
vkubiv
force-pushed
the
feat-split-wallet-command
branch
from
f094059 to
55bfc82
Compare
sudeshrshetty
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Split wallet command.
Summary:
Factor walletlite.Command form vcwallet.Command. It can now be used in the lite version of an agent that does not require didcomm functionality.