Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

refactor: separate didcomm from wallet. #3264

Merged

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Jun 27, 2022

Signed-off-by: Volodymyr Kubiv volodymyr.kubiv@euristiq.com

Title:
Separate DidComm code from Wallet

Description:
To make it possible to use Wallet with our DidComm functionality and required services, DidComm was separated from wallet

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3264 (512704a) into main (82112d1) will decrease coverage by 0.07%.
The diff coverage is 89.73%.

@@            Coverage Diff             @@
##             main    #3264      +/-   ##
==========================================
- Coverage   88.34%   88.27%   -0.08%     
==========================================
  Files         311      312       +1     
  Lines       42384    42436      +52     
==========================================
+ Hits        37446    37461      +15     
- Misses       3626     3658      +32     
- Partials     1312     1317       +5     
Impacted Files Coverage Δ
pkg/controller/command/vcwallet/command.go 92.67% <29.62%> (-4.52%) ⬇️
pkg/wallet/didcomm.go 97.87% <97.87%> (ø)
pkg/client/vcwallet/client.go 100.00% <100.00%> (ø)
pkg/wallet/wallet.go 98.70% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566dff8...512704a. Read the comment docs.

@vkubiv vkubiv force-pushed the feat-separate-didcom-wallet branch from 5e50ffc to 5b55580 Compare June 27, 2022 13:23
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@fqutishat fqutishat force-pushed the feat-separate-didcom-wallet branch from 5b55580 to 512704a Compare June 29, 2022 15:57
@sudeshrshetty sudeshrshetty merged commit 15a4bb4 into hyperledger-archives:main Jul 12, 2022
Abdulbois pushed a commit to Abdulbois/aries-framework-go that referenced this pull request Jul 13, 2022
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants