This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: re enable remote kms bdd-tests with unwrapKey #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baha-ai
force-pushed
the
merge_easy_keyWrap
branch
from
406d3db to
ca16de4
Compare
baha-ai
changed the title
baha-ai
force-pushed
the
merge_easy_keyWrap
branch
from
ca16de4 to
44181d9
Compare
baha-ai
changed the title
This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations. closes hyperledger-archives#3262 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com>
baha-ai
force-pushed
the
merge_easy_keyWrap
branch
from
44181d9 to
1158944
Compare
Codecov Report
@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
- Coverage 88.39% 88.37% -0.02%
==========================================
Files 311 311
Lines 42309 42324 +15
==========================================
+ Hits 37399 37405 +6
- Misses 3603 3609 +6
- Partials 1307 1310 +3
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Jun 14, 2022
aholovko
approved these changes
Jun 14, 2022
Abdulbois
pushed a commit
to Abdulbois/aries-framework-go
that referenced
this pull request
Jul 13, 2022
…archives#3263) This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations. closes hyperledger-archives#3262 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Abdulbois
pushed a commit
to Abdulbois/aries-framework-go
that referenced
this pull request
Jul 16, 2022
…archives#3263) This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations. closes hyperledger-archives#3262 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
fqutishat
pushed a commit
that referenced
this pull request
Jul 18, 2022
…ds while creating forward message. Add legacyForward model (#3272) * refactor: remote cryptobox URLs renamed to /wrap and /unwrap (#3259) this change updates the remote CryptoBox api URIs to point to remote KMS's key /wrap and /unwrap to match ECDH-ES and ECDH-1PU key wrapping. This change requires the KMS server to udpate /easy to /wrap, /easyOpen and /sealOpen to /unwrap Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com> * refactor: re enable remote kms bdd-tests with unwrapKey (#3263) This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations. closes #3262 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com> * refactor: Enable usage of legacy Anoncrypt packer. Make nested forwards while creating forward message. Add legacyForward model - Add legacy Anoncrypt packer while creating packers - Add ability to create nested packed forwards (one nested forward for each routing key) - Check and convert msg field of Forward to Envelope in order to support DIDComm V1 Forward types - Revert part of 04bfea8 commit related to generating keys inside mediator service. Because with previous changes (having two types of generated keys belonging to the same router) it breaks Route Coordination protocol (while creating nested forwards it will pack two times to the same mediator then mediator cannot handle second forward message) Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com> * refactor: Remove test due to forcing anoncrypt while calling createForwardMessage. Fix lint errors Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com> Co-authored-by: Baha <29608896+Baha-sk@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations.
closes #3262
Signed-off-by: Baha Shaaban baha.shaaban@securekey.com