This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Full EDV provider support for AND+OR multiple tag queries #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
EDVProviderAndORMultipleTagQuery
branch
from
b648e9e to
ae7743d
Compare
This was referenced Jun 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #3252 +/- ##
==========================================
- Coverage 88.41% 88.39% -0.03%
==========================================
Files 310 310
Lines 42264 42273 +9
==========================================
- Hits 37369 37367 -2
- Misses 3591 3601 +10
- Partials 1304 1305 +1
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
EDVProviderAndORMultipleTagQuery
branch
from
ae7743d to
853654a
Compare
The EDV storage provider can now do full AND+OR tag querying. The SetStoreConfig method no longer calls the "add index" endpoint as it won't be added to the spec (indexing will be automatically by the EDV server). Also updated storage interface documentation for the Query method to accommodate the new functionality. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
EDVProviderAndORMultipleTagQuery
branch
from
853654a to
72c885b
Compare
bstasyszyn
approved these changes
Jun 3, 2022
troyronda
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EDV storage provider can now do full AND+OR tag querying. The SetStoreConfig method no longer calls the "add index" endpoint as it won't be added to the spec (indexing will be automatically by the EDV server).
Also updated storage interface documentation for the Query method to accommodate the new functionality.
Signed-off-by: Derek Trider Derek.Trider@securekey.com