This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: add support of multibase encoding for proofValue. #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3244 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 309 309
Lines 41727 41766 +39
==========================================
+ Hits 37030 37064 +34
- Misses 3421 3425 +4
- Partials 1276 1277 +1
Continue to review full report at Codecov.
|
vkubiv
force-pushed
the
feat-multibase-encoding-proofvalue
branch
7 times, most recently
from
c50e89f to
223bc4e
Compare
rolsonquadras
requested review from
Moopli,
sudeshrshetty,
fqutishat,
aholovko,
rolsonquadras and
baha-ai
rolsonquadras
approved these changes
May 20, 2022
aholovko
approved these changes
May 20, 2022
sudeshrshetty
approved these changes
May 24, 2022
sudeshrshetty
suggested changes
May 24, 2022
|
Lets keep this multibase changes limited to ED255192020 |
vkubiv
force-pushed
the
feat-multibase-encoding-proofvalue
branch
3 times, most recently
from
810145e to
d1c9773
Compare
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
vkubiv
force-pushed
the
feat-multibase-encoding-proofvalue
branch
from
d1c9773 to
da77875
Compare
sudeshrshetty
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Kubiv volodymyr.kubiv@euristiq.com
Title:
Add support of multibase encoding for proofValue.
Description:
#3228
Summary:
Add support of multibase encoding for proofValue and update unit tests to reflect this change.