This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Add multi-tag support to mem DB #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mem DB now supports queries with multiple tags using the '&&' operator. Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #3242 +/- ##
=======================================
Coverage 88.74% 88.75%
=======================================
Files 309 309
Lines 41727 41752 +25
=======================================
+ Hits 37030 37055 +25
Misses 3421 3421
Partials 1276 1276
Continue to review full report at Codecov.
|
DRK3
approved these changes
May 16, 2022
fqutishat
approved these changes
May 16, 2022
DRK3
reviewed
May 16, 2022
| }) | ||
|
|
||
| t.Run("Invalid value for tag -> no results", func(t *testing.T) { | ||
| iterator, err := store.Query("TagName1:TagValueX") |
There was a problem hiding this comment.
I think this is a valid tag value, it's just that there happens to be no results. When I think of an "invalid" tag value, I think of one that contains a : character, for instance.
There was a problem hiding this comment.
I guess I shouldn't have said 'invalid'. Instead, non-matching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mem DB now supports queries with multiple tags using the '&&' operator.
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com