Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: add an option to disable required properties for CredentialParse. #3241

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented May 12, 2022

Signed-off-by: Volodymyr Kubiv volodymyr.kubiv@euristiq.com

Title:
Add an option for CredentialParse to use customized vc default schema.

Description:
trustbloc/vcs#725

Summary:

Now CredentialParse can use a customized vc default schema.
CreateDefaultSchema function added to simplify the creation of custom default schema.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3241 (bf640b8) into main (261c374) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
+ Coverage   88.73%   88.74%   +0.01%     
==========================================
  Files         309      309              
  Lines       41689    41727      +38     
==========================================
+ Hits        36992    37030      +38     
  Misses       3421     3421              
  Partials     1276     1276              
Impacted Files Coverage Δ
pkg/doc/verifiable/credential.go 90.99% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261c374...bf640b8. Read the comment docs.

@vkubiv vkubiv force-pushed the feat-credential-parse-issuance-date branch 2 times, most recently from ad7df9a to aa5f611 Compare May 13, 2022 07:47
Copy link
Contributor

@rolsonquadras rolsonquadras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment. Overall looks good.

pkg/doc/verifiable/credential.go Outdated Show resolved Hide resolved
@vkubiv vkubiv force-pushed the feat-credential-parse-issuance-date branch from aa5f611 to 0cf09dd Compare May 16, 2022 07:18
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the feat-credential-parse-issuance-date branch from 0cf09dd to bf640b8 Compare May 16, 2022 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants