-
Notifications
You must be signed in to change notification settings - Fork 160
externalize agent parameters + router #3229
externalize agent parameters + router #3229
Conversation
FYI @troyronda @rolsonquadras @borancar this is released to #3224 to remove the copied/pasted aries.go we added |
@rolsonquadras I fixed some linting issues can you allow the workflows to run? |
@rolsonquadras sorry for the back and fourth, i enabled GH Actions on my Fork to get all the other Unit Test/Linting issues resolved. We should be good to go now if you can run workflows once again! |
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com> Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
The method always returns nil. It's there just to allow it to implement a "Pinger" sort of interface which may be defined somewhere. Signed-off-by: Derek Trider <Derek.Trider@securekey.com> Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
@cnuss - tagging @sudeshrshetty @fqutishat @troyronda as they have access to run the workflows |
13d9cd9
to
e03e60c
Compare
Codecov Report
@@ Coverage Diff @@
## main #3229 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 309 309
Lines 41704 41716 +12
=======================================
+ Hits 37002 37014 +12
Misses 3424 3424
Partials 1278 1278
Continue to review full report at Codecov.
|
@cnuss It looks like the branch is out-of-date with the base branch. |
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
@troyronda thank you, i just sync'd with main! could you trigger GH Actions again? also added a unit test to get hopefully get codecov in order 🙏 |
Signed-off-by: Christian Nuss <christian.nuss@gmail.com>
@troyronda @sudeshrshetty @fqutishat these linting issues, first time collaborator pauses, and codecov breakages are really frustrating, and the only way i can figure out i've done something wrong is by committing then waiting could one of you you attempt to push this PR over the finish line? i'm now having an unrelated unit test failure, probably because i'm using os.Setenv (appartently i can't use t.Setenv because we're on an older version of go?) i've given each of you maintainer access to https://github.com/scaffoldly/aries-framework-go |
@cnuss This PR has been merged. Thanks for your contribution! |
Title:
Allow External Usage of
agentParameters
andmux.Router
Description:
To allow for another server framework than golang's
http
, we need to externalize the creation ofmux.NewRouter()
.Summary:
Related: #3224
When @borancar and I first authored #3224, we copied and pasted
start.go
and named itaires.go
to gain access tomux.NewRouter()
, so we could plug it into another server framework, as Lambda does not use golang'shttp
package, however it is compatible with gorillamux.So this PR allows us to import
startcmd
and leverage a couple new functions:NewAgentParameters()
AgentParameters
is now an exported typeAgentParameters
has a new method:NewRouter()
cobra.Command
nil
when constructingAgentParameters