refactor: endpoint as object, goal-code with underscore #3223

baha-ai · 2022-04-20T15:33:13Z

Following this DIDcomm V2 spec udpate:
decentralized-identity/didcomm-messaging#352
The endpoint field is now a structure containing a URI, Accept and the RoutingKeys.
and
decentralized-identity/didcomm-messaging#363
goal-code is now goal_code.

Signed-off-by: Baha Shaaban baha.shaaban@securekey.com

codecov · 2022-04-21T13:50:48Z

Codecov Report

Merging #3223 (1b2819a) into main (5d239d5) will decrease coverage by 0.00%.
The diff coverage is 92.05%.

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   88.73%   88.73%   -0.01%     
==========================================
  Files         309      309              
  Lines       41646    41689      +43     
==========================================
+ Hits        36956    36994      +38     
- Misses       3415     3419       +4     
- Partials     1275     1276       +1

Impacted Files	Coverage Δ
pkg/client/didexchange/client.go	`92.59% <ø> (-0.03%)`	⬇️
pkg/didcomm/common/service/destination.go	`100.00% <ø> (ø)`
pkg/didcomm/protocol/introduce/models.go	`100.00% <ø> (ø)`
pkg/store/connection/connection_lookup.go	`94.25% <ø> (ø)`
pkg/wallet/invitation.go	`96.73% <ø> (ø)`
pkg/client/outofband/client.go	`70.29% <12.50%> (-0.60%)`	⬇️
pkg/vdr/peer/creator.go	`88.96% <50.00%> (ø)`
pkg/doc/did/doc.go	`87.05% <88.46%> (-0.01%)`	⬇️
pkg/didcomm/protocol/didexchange/states.go	`90.12% <94.11%> (+0.03%)`	⬆️
pkg/client/connection/client.go	`89.24% <100.00%> (+0.35%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d239d5...1b2819a. Read the comment docs.

pkg/client/issuecredential/client.go

pkg/client/presentproof/client.go

pkg/didcomm/common/model/ack.go

pkg/didcomm/common/model/problem_report.go

pkg/didcomm/protocol/issuecredential/models.go

pkg/didcomm/protocol/issuecredential/service.go

Following this DIDcomm V2 spec udpate: decentralized-identity/didcomm-messaging#352 The endpoint field is now a structure containing a URI, Accept and the RoutingKeys. Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com>

Following this DIDcomm V2 spec udpate: decentralized-identity/didcomm-messaging#363 goal-code is now goal_code. Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com>

baha-ai force-pushed the endpoint_refactor branch 9 times, most recently from 18b65a4 to 1e09c4e Compare April 21, 2022 13:43

baha-ai force-pushed the endpoint_refactor branch 6 times, most recently from fd4c796 to deb50fd Compare April 21, 2022 17:15

baha-ai changed the title ~~refactor: endpoint change from string to struct~~ refactor: endpoint as object, goal-code and web-redirect with underscore Apr 21, 2022

baha-ai requested review from sudeshrshetty, troyronda, Moopli, fqutishat and rolsonquadras April 21, 2022 17:17