This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
docs: Updated storage interface documentation #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3216 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 309 309
Lines 41644 41644
=======================================
Hits 36954 36954
Misses 3415 3415
Partials 1275 1275 Continue to review full report at Codecov.
|
bstasyszyn
approved these changes
Apr 11, 2022
fqutishat
force-pushed
the
StorageInterfaceDocUpdateTagsSharedTagName
branch
from
7e99771 to
85c401f
Compare
DRK3
force-pushed
the
StorageInterfaceDocUpdateTagsSharedTagName
branch
from
85c401f to
6965916
Compare
Updated the documentation for the Put method to indicate that in the set of tags used on a single Put call, those tags must have unique tag names. The reason for this is because several of our major storage implementations in aries-framework-go-ext have this implementation, so this note was added to help ensure consistent behaviour. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
StorageInterfaceDocUpdateTagsSharedTagName
branch
from
6965916 to
2825074
Compare
fqutishat
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation for the Put method to indicate that in the set of tags used on a single Put call, those tags must have unique tag names. The reason for this is because several of our major storage implementations in aries-framework-go-ext have this implementation, so this note was added to help ensure consistent behaviour.
Signed-off-by: Derek Trider Derek.Trider@securekey.com