fix: id format in vp (#3402)

Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com> Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
hyperledger-archives · Oct 17, 2022 · a3afb8a · a3afb8a
1 parent fc30798
commit a3afb8a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/pkg/doc/verifiable/presentation.go b/pkg/doc/verifiable/presentation.go
@@ -56,8 +56,7 @@ const basePresentationSchema = `
       ]
     },
     "id": {
-      "type": "string",
-      "format": "uri"
+      "type": "string"
     },
     "type": {
       "oneOf": [

diff --git a/pkg/doc/verifiable/presentation_test.go b/pkg/doc/verifiable/presentation_test.go
@@ -348,16 +348,14 @@ func TestValidateVP_Context(t *testing.T) {
 }
 
 func TestValidateVP_ID(t *testing.T) {
-	t.Run("rejects verifiable presentation with non-url ID", func(t *testing.T) {
+	t.Run("accept verifiable presentation with string ID", func(t *testing.T) {
 		raw := &rawPresentation{}
 		require.NoError(t, json.Unmarshal([]byte(validPresentation), &raw))
-		raw.ID = "not valid presentation ID URL"
+		raw.ID = "id"
 		bytes, err := json.Marshal(raw)
 		require.NoError(t, err)
-		vp, err := newTestPresentation(t, bytes)
-		require.Error(t, err)
-		require.Contains(t, err.Error(), "id: Does not match format 'uri'")
-		require.Nil(t, vp)
+		_, err = newTestPresentation(t, bytes)
+		require.NoError(t, err)
 	})
 }