Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add BOB, Mantle, Taiko #72

Merged
merged 23 commits into from
Jul 2, 2024
Merged

feat: Add BOB, Mantle, Taiko #72

merged 23 commits into from
Jul 2, 2024

Conversation

avious00
Copy link
Contributor

Description

Type: New Network

Network(s): BOB, Mantle, Taiko

Other notes

Corresponding issue, fixes: https://github.com/hyperlane-xyz/issues/issues/1289

@avious00 avious00 requested a review from paulbalaji June 24, 2024 12:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 72682af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paulbalaji paulbalaji changed the title Add BOB, Mantle, Taiko feat: Add BOB, Mantle, Taiko Jun 24, 2024
@paulbalaji
update taiko estimate block time
b423d27 
Signed-off-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
jmrossy
jmrossy reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm none of these chains are scrapped? If they are, please add the scrapped ones to the CoreChains enum in /src/core/

chains/bob/logo.svg Outdated Show resolved Hide resolved
chains/mantle/logo.svg Outdated Show resolved Hide resolved
@paulbalaji
CR rossy
0dd2e40 
Signed-off-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji
trim surrounding on mantle logo
7746e8c
@avious00
Copy link
Contributor Author

Can you confirm none of these chains are scrapped? If they are, please add the scrapped ones to the CoreChains enum in /src/core/

hey @jmrossy could you confirm this more for my future reference? if these are AW-run and added to scraper, then i should also add to /src/core/chain.ts

@paulbalaji
add safe api for taiko
e3055e3 
Signed-off-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji
deploy ism factories
6ef31ba
@jmrossy
Copy link
Collaborator

jmrossy commented Jun 24, 2024 •
edited
Loading

hey @jmrossy could you confirm this more for my future reference? if these are AW-run and added to scraper, then i should also add to /src/core/chain.ts

@avious00 correct. Until hyperlane-xyz/hyperlane-explorer#74 is done, that's required to show up in the explorer's dropdown list

@jmrossy
Copy link
Collaborator

jmrossy commented Jun 24, 2024

@paulbalaji @avious00 Also need a changeset here please

paulbalaji and others added 3 commits June 25, 2024 11:05
@paulbalaji
add safe tx url for bob
d3fd1e9 
Signed-off-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji
add changeset
c0d243e
@jmrossy
Optimize new logos
3416afd
@paulbalaji paulbalaji marked this pull request as draft June 25, 2024 13:07
@paulbalaji
core deploy to bob, mantle, taiko
4e57736
@paulbalaji
lint:fix
f36c4ac 
Signed-off-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji
full core deploy
493ac6c
@paulbalaji
update metadata
2f0e46b
@paulbalaji
enroll new validators
c583331 
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji paulbalaji marked this pull request as ready for review July 1, 2024 17:01
paulbalaji added 2 commits July 2, 2024 12:34
@paulbalaji
Merge branch 'main' into sprint27
e04f7c0
@paulbalaji
add previous deploys to CoreMainnets
0f2c49d 
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji paulbalaji requested a review from jmrossy July 2, 2024 11:43
jmrossy
jmrossy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chains/mantle/metadata.yaml Outdated Show resolved Hide resolved
@jmrossy jmrossy enabled auto-merge July 2, 2024 14:53
@jmrossy jmrossy added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 0f636ee Jul 2, 2024
6 checks passed
@jmrossy jmrossy deleted the sprint27 branch July 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy approved these changes

@paulbalaji paulbalaji Awaiting requested review from paulbalaji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avious00 @jmrossy @paulbalaji