Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance block explorer utility tests with edge cases and multiple explorers #5147

Merged

Conversation

tiendn
Copy link
Contributor

@tiendn tiendn commented Jan 10, 2025

Description

  • Added comprehensive tests for block explorer utilities, covering edge cases such as chains without block explorers and chains without API URLs.
  • Implemented tests for handling multiple block explorers, ensuring correct explorer selection by index.
  • Included tests for special chain names and proper URL handling, particularly with trailing slashes.

Drive-by changes

Related issues

Backward compatibility

Testing

All new tests have been implemented and verified for correctness.

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: ede099b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jmrossy
Copy link
Contributor

jmrossy commented Jan 10, 2025

@tiendn Thanks for the PR. CI seems to be failing but I don't know why. Try pulling latest from upstream main into your branch.

@tiendn
Copy link
Contributor Author

tiendn commented Jan 11, 2025

@tiendn Thanks for the PR. CI seems to be failing but I don't know why. Try pulling latest from upstream main into your branch.

Oh sorry, I pulled it, please check again.

@tiendn tiendn force-pushed the test/update-more-testcase-blockexplore branch from ede099b to 225c11a Compare January 11, 2025 01:04
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (5765587) to head (225c11a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5147   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@jmrossy jmrossy enabled auto-merge January 11, 2025 13:23
@jmrossy jmrossy added this pull request to the merge queue Jan 11, 2025
Merged via the queue into hyperlane-xyz:main with commit 585404d Jan 11, 2025
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants