Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): made processInboundMessage payable to mock send value via mailbox.process #4797

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

aroralanuk
Copy link
Contributor

Description

processInboundMessage needs to be payable for mocking sending value for ICA router call

Drive-by changes

None

Related issues

None

Backward compatibility

Yes

Testing

None

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: a6ba217

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/core Minor
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (fa06690) to head (a6ba217).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4797   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files         101      101           
  Lines        1481     1481           
  Branches      192      192           
=======================================
  Hits         1100     1100           
  Misses        360      360           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.77% <ø> (ø)
isms 77.77% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

@aroralanuk aroralanuk added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit a82b4b4 Nov 5, 2024
36 checks passed
@aroralanuk aroralanuk deleted the kunal/payable-mock-process branch November 5, 2024 13:48
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
…ue via mailbox.process (hyperlane-xyz#4797)

### Description

processInboundMessage needs to be payable for mocking sending value for
ICA router call

### Drive-by changes

None

### Related issues

None

### Backward compatibility

Yes

### Testing

None
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
…ue via mailbox.process (hyperlane-xyz#4797)

### Description

processInboundMessage needs to be payable for mocking sending value for
ICA router call

### Drive-by changes

None

### Related issues

None

### Backward compatibility

Yes

### Testing

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants