Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli command for verify warp route contracts #4768

Merged
merged 21 commits into from
Nov 1, 2024
Merged

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Oct 25, 2024

Description

Uses warp artifacts to derive the verification artifacts from etherscan and RPC api.

usage: hyperlane warp verify --symbol

Drive-by

  • Write to registry when blockexplorer api keys are added

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 45daece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ltyu ltyu marked this pull request as draft October 28, 2024 15:50
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (7e9e248) to head (45daece).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4768   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         101      101           
  Lines        1466     1466           
  Branches      191      191           
=======================================
  Hits         1085     1085           
  Misses        360      360           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 76.41% <ø> (ø)
isms 77.58% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

@ltyu ltyu marked this pull request as ready for review November 1, 2024 16:32
@ltyu ltyu requested a review from xeno097 November 1, 2024 16:32
Copy link
Contributor

@xeno097 xeno097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

typescript/sdk/src/deploy/verify/utils.ts Outdated Show resolved Hide resolved
typescript/cli/src/verify/warp.ts Outdated Show resolved Hide resolved
@ltyu ltyu added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit db5875c Nov 1, 2024
32 checks passed
@ltyu ltyu deleted the ltyu/cli-verify-contracts branch November 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants