Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): quote management for L2->L1 hooks #4552

Merged
merged 56 commits into from
Oct 31, 2024
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
1560f5c
add fix
aroralanuk Sep 5, 2024
44379e1
move to inside
aroralanuk Sep 13, 2024
d680e50
opl2tol1
aroralanuk Sep 16, 2024
ca26e88
arb
aroralanuk Sep 16, 2024
a5c4b62
rm revertWhen_invalidMetadata
aroralanuk Sep 16, 2024
54b4327
msg_value
aroralanuk Sep 16, 2024
66c3bb7
direct call
aroralanuk Sep 16, 2024
e98382d
invalid ism
aroralanuk Sep 16, 2024
56ea53c
no both branch test
aroralanuk Sep 16, 2024
30982d2
unauth hook
aroralanuk Sep 17, 2024
88cb33f
invalid messageId
aroralanuk Sep 17, 2024
baef8ff
5164
aroralanuk Sep 17, 2024
9684835
try catch
aroralanuk Sep 17, 2024
6c31fbf
formatting
aroralanuk Sep 17, 2024
f64611d
opstack
aroralanuk Sep 18, 2024
ac3613e
minor edits
aroralanuk Sep 18, 2024
4d293ea
minor fixes
aroralanuk Sep 18, 2024
fb66306
override inconsistent tests
aroralanuk Sep 18, 2024
13c61fd
Merge branch 'kunal/external-bridge-refactor' into kunal/HL2408-002-fix
aroralanuk Sep 20, 2024
fb089e2
opstack change quote
aroralanuk Sep 20, 2024
c70ac54
Merge branch 'kunal/external-bridge-refactor' into kunal/HL2408-002-fix
aroralanuk Sep 20, 2024
e6c5b10
fix tests
aroralanuk Sep 20, 2024
08dda88
remove reduntant arbitrary call
aroralanuk Sep 20, 2024
37ecb27
rm
aroralanuk Sep 20, 2024
1dd0fc3
changeset
aroralanuk Sep 20, 2024
c99eb24
add verifyMessageId
aroralanuk Sep 20, 2024
97b7bc8
add test
aroralanuk Sep 20, 2024
c6b5f76
Merge branch 'main' into kunal/verify-message-id
aroralanuk Sep 20, 2024
bef3470
add to current value
aroralanuk Sep 20, 2024
541be43
revert
aroralanuk Sep 20, 2024
4233c0a
magic
aroralanuk Sep 20, 2024
41a407d
5164
aroralanuk Sep 20, 2024
5610c33
changeset
aroralanuk Sep 20, 2024
ef780c6
check sufficient fees and return extra
aroralanuk Sep 23, 2024
a6731b0
changeset
aroralanuk Sep 23, 2024
47defbf
Merge branch 'main' into kunal/HL2408-002-fix
aroralanuk Sep 24, 2024
8510b6a
add childhook
aroralanuk Sep 24, 2024
a1a850e
add tests
aroralanuk Sep 24, 2024
7ba121d
inter
aroralanuk Sep 25, 2024
101fe72
Merge branch 'kunal/check-suff-refund-extra' into kunal/verify-messag…
aroralanuk Sep 25, 2024
cc69d2e
hook encode fix
aroralanuk Sep 25, 2024
a0aaf23
add msgvalue to quote
aroralanuk Sep 25, 2024
5d90cfe
Merge branch 'kunal/check-suff-refund-extra' into kunal/verify-messag…
aroralanuk Sep 25, 2024
43eba79
revert
aroralanuk Sep 25, 2024
750d09b
spelling
aroralanuk Sep 26, 2024
5991022
Merge branch 'main' into kunal/HL2408-002-fix
aroralanuk Sep 26, 2024
71d23f4
Merge branch 'kunal/HL2408-002-fix' into kunal/check-suff-refund-extra
aroralanuk Sep 26, 2024
8df9105
rm changeset
aroralanuk Sep 26, 2024
9093369
small
aroralanuk Oct 4, 2024
56c6b1d
fix LZ double refund
aroralanuk Oct 23, 2024
01247ce
Merge branch 'main' into kunal/check-suff-refund-extra
aroralanuk Oct 29, 2024
e16958e
docs(changeset): Checking for sufficient fees in `AbstractMessageIdAu…
aroralanuk Oct 29, 2024
64e7628
rm
aroralanuk Oct 29, 2024
1ed932d
docs(changeset): Checking for sufficient fees in `AbstractMessageIdAu…
aroralanuk Oct 29, 2024
255f598
arb l2->l1 sdk fix
aroralanuk Oct 30, 2024
5edc95a
test1->test4
aroralanuk Oct 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test1->test4
  • Loading branch information
aroralanuk committed Oct 31, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5edc95a54487d6589f0d125d80d2f05c30f16bea
10 changes: 5 additions & 5 deletions typescript/sdk/src/ism/metadata/arbL2ToL1.hardhat-test.ts
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ import { ArbL2ToL1MetadataBuilder } from './arbL2ToL1.js';
import { MetadataContext } from './builder.js';

describe('ArbL2ToL1MetadataBuilder', () => {
const origin: ChainName = 'test1';
const origin: ChainName = 'test4';
const destination: ChainName = 'test2';
let core: HyperlaneCore;
let ismFactory: HyperlaneIsmFactory;
@@ -93,7 +93,7 @@ describe('ArbL2ToL1MetadataBuilder', () => {
[],
);
hookConfig = {
test1: {
test4: {
type: HookType.ARB_L2_TO_L1,
arbSys: mockArbSys.address,
destinationChain: destination,
@@ -115,7 +115,7 @@ describe('ArbL2ToL1MetadataBuilder', () => {
},
};

factoryContracts = contractsMap.test1;
factoryContracts = contractsMap.test4;
proxyFactoryAddresses = Object.keys(factoryContracts).reduce((acc, key) => {
acc[key] =
contractsMap[origin][key as keyof ProxyFactoryFactories].address;
@@ -126,11 +126,11 @@ describe('ArbL2ToL1MetadataBuilder', () => {
new MockArbBridge__factory(),
[],
);
hookConfig.test1.bridge = arbBridge.address;
hookConfig.test4.bridge = arbBridge.address;

const hookModule = await EvmHookModule.create({
chain: origin,
config: hookConfig.test1,
config: hookConfig.test4,
proxyFactoryFactories: proxyFactoryAddresses,
coreAddresses: core.getAddresses(origin),
multiProvider,
Loading