fix(evm): only create signer provider when needed

[daniel-savu]

Description

Adds an associated const to all ethereum provider builders to specify whether a signer is needed. For an e2e run with 20 messages, we now have 12 providers built with signers at the beginning (3 of which are validator announce), and 708 providers built without a signer. This should hopefully fix the gas escalator memory leak.

Drive-by changes

Related issues

Backward compatibility

Testing

[changeset-bot]

⚠️ No Changeset found

Latest commit: 44bdb6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (cfb890d) to head (44bdb6c).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #4208   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         14      14           
=====================================
  Misses        14      14           

Components	Coverage Δ
core	∅ <ø> (∅)
hooks	∅ <ø> (∅)
isms	∅ <ø> (∅)
token	∅ <ø> (∅)
middlewares	∅ <ø> (∅)

[tkporter]

Just wanna make sure batching still works fine? I assume so as we create the multicall here with the Mailbox provider https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/rust/chains/hyperlane-ethereum/src/contracts/mailbox.rs#L502

[daniel-savu]

Just wanna make sure batching still works fine? I assume so as we create the multicall here with the Mailbox provider https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/rust/chains/hyperlane-ethereum/src/contracts/mailbox.rs#L502

@tkporter batches are still successfully sent in e2e:

2024-07-26T16:39:09.2561535Z <RLY> 2024-07-26T16:39:08.757633Z  INFO submit_task: relayer::msg::op_submitter: Submitted transaction batch batch_size=3 outcome=TxOutcome { transaction_id: 0x00000000000000000000000000000000000000000000000000000000000000004d141a1cfa0ba55bc68d066bce86718d35817f3a19530f04de19f88474353f6f, executed: true, gas_used: 386210, gas_price: FixedPointNumber(BigDecimal("1500000008")) } batch=[PendingMessage { num_retries: 0, since_last_attempt_s: 5, next_attempt_after_s: 0, message: HyperlaneMessage { id: 0x0b272ed8392c57e889ca16c5d4a473b4f57d096202ba70f389d1a44a3442223a, version: 3, nonce: 0, origin: test3, sender: 0xb82008565fdc7e44609fa118a4a681e92581e680, destination: test1, recipient: 0xb82008565fdc7e44609fa118a4a681e92581e680, body: 0x1234 }, status: ReadyToSubmit, app_context: None }, PendingMessage { num_retries: 0, since_last_attempt_s: 4, next_attempt_after_s: 0, message: HyperlaneMessage { id: 0xa4f8613651ed250cc0f399c38917122e4b18ddc697abc126908596d90f16c01c, version: 3, nonce: 0, origin: test2, sender: 0xb82008565fdc7e44609fa118a4a681e92581e680, destination: test1, recipient: 0xb82008565fdc7e44609fa118a4a681e92581e680, body: 0x1234 }, status: ReadyToSubmit, app_context: None }, PendingMessage { num_retries: 0, since_last_attempt_s: 6, next_attempt_after_s: 0, message: HyperlaneMessage { id: 0x5305762c0f2dae98812fad3ee21bbe05cf020c1bec362fc2c2c9849799a9e764, version: 3, nonce: 4, origin: test2, sender: 0x870526b7973b56163a6997bb7c886f5e4ea53638, destination: test1, recipient: 0x870526b7973b56163a6997bb7c886f5e4ea53638, body: 0x1234 }, status: ReadyToSubmit, app_context: None }] excluded_ops=[] domain=test1

[daniel-savu]

actually a good takeaway from your comment is to add an invariant so the count of Submitted transaction batch logs is nonzero 👍