Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warp configure infinite loop #3929

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix: warp configure infinite loop #3929

merged 3 commits into from
Jun 10, 2024

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jun 10, 2024

Description

  • Fixes hyperlane warp configure ism selection looping by configuring a default Aggregation ISM with trusted relayer and fallback routing

Related issues

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 1dbe2e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.76%. Comparing base (3283eef) to head (1dbe2e1).

Additional details and impacted files
@@           Coverage Diff            @@
##           cli-2.0    #3929   +/-   ##
========================================
  Coverage    62.76%   62.76%           
========================================
  Files          125      125           
  Lines         1579     1579           
  Branches       175      175           
========================================
  Hits           991      991           
  Misses         561      561           
  Partials        27       27           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 39.52% <ø> (ø)
token 60.83% <ø> (ø)
middlewares 77.05% <ø> (ø)

@ltyu ltyu force-pushed the ltyu/warp-config-loop-fix branch from a66fea5 to a162c69 Compare June 10, 2024 12:44
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one small thing

typescript/cli/src/config/warp.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nbayindirli nbayindirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ltyu ltyu enabled auto-merge June 10, 2024 14:41
@ltyu ltyu added this pull request to the merge queue Jun 10, 2024
Merged via the queue into cli-2.0 with commit 4040db7 Jun 10, 2024
30 of 32 checks passed
@ltyu ltyu deleted the ltyu/warp-config-loop-fix branch June 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants