Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript relayer MVP #3693

Merged
merged 76 commits into from
Jul 17, 2024
Merged

feat: typescript relayer MVP #3693

merged 76 commits into from
Jul 17, 2024

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented May 1, 2024

Description

  • implement HyperlaneRelayer as a wrapper around HyperlaneCore
  • add relaying to CLI status command
  • add infra script relay for an environment

Drive-by changes

Related issues

Backward compatibility

Testing

Manual

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 25aff26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/infra Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/ccip-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (74cd350) to head (25aff26).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3693   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         14      14           
=====================================
  Misses        14      14           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@yorhodes yorhodes changed the title self relay polling Typescript relayer MVP May 2, 2024
@yorhodes yorhodes marked this pull request as ready for review May 2, 2024 21:10
@yorhodes yorhodes requested a review from aroralanuk as a code owner May 3, 2024 15:11
@aroralanuk aroralanuk changed the title feat(sdk):typescript relayer MVP feat: typescript relayer MVP Jun 28, 2024
@jmrossy
Copy link
Contributor

jmrossy commented Jul 1, 2024

@aroralanuk @yorhodes I see there's new activity here. Should I re-review this now?

@aroralanuk
Copy link
Contributor

@aroralanuk @yorhodes I see there's new activity here. Should I re-review this now?

Yes, that will be great!

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a great new feature but the design of it will have broad implications and so probably merits more scrutiny. More practically speaking, there are a bunch of valid older comments that haven't been addressed yet (plus my new ones) so still some work needed I think.

typescript/cli/src/status/message.ts Show resolved Hide resolved
typescript/cli/src/status/message.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/HyperlaneCore.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/HyperlaneCore.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/HyperlaneRelayer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/metadata/ChainMetadataManager.ts Outdated Show resolved Hide resolved
typescript/sdk/src/providers/MultiProvider.ts Show resolved Hide resolved
typescript/utils/src/addresses.ts Outdated Show resolved Hide resolved
typescript/utils/src/addresses.ts Outdated Show resolved Hide resolved
typescript/utils/package.json Outdated Show resolved Hide resolved
@aroralanuk aroralanuk enabled auto-merge July 15, 2024 05:46
@aroralanuk aroralanuk disabled auto-merge July 15, 2024 05:53
@aroralanuk aroralanuk enabled auto-merge July 17, 2024 01:49
@aroralanuk aroralanuk disabled auto-merge July 17, 2024 01:53
@aroralanuk aroralanuk enabled auto-merge July 17, 2024 01:54
@aroralanuk aroralanuk added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 388d255 Jul 17, 2024
35 of 38 checks passed
@aroralanuk aroralanuk deleted the self-relay-polling branch July 17, 2024 02:33
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2024
### Description

Adds the CLI equivalent of #3693. Should mostly be used only for demo
purposes with reliable RPCs in the registry. Includes some drive-by
changes to the existing single-message self-relay.

### Drive-by changes

- Self-relay fixes


### Backward compatibility


Yes

### Testing

Manual

---------

Co-authored-by: J M Rossy <jm.rossy@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2024
### Description

Adds the CLI equivalent of #3693. Should mostly be used only for demo
purposes with reliable RPCs in the registry. Includes some drive-by
changes to the existing single-message self-relay.

### Drive-by changes

- Self-relay fixes


### Backward compatibility


Yes

### Testing

Manual

---------

Co-authored-by: J M Rossy <jm.rossy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants